From: <apn...@ya...> - 2025-06-30 11:11:26
|
Nicolas, Thanks for testing. Please do file a ticket at https://github.com/tcltk-depot/tkpath/issues. If you are conversant enough with MacOS to suggest patch, a pull request would be even better. Did you run the test suite and / or demos after compilation? If so, were the result any different from what Paul reported? /Ashok From: nicolas bats <sl1...@gm...> Sent: Monday, June 30, 2025 11:51 AM To: apn...@ya... Cc: tcl...@li... Subject: Re: [TCLCORE] TkPath 0.4.1 Hi Paul, Ashok, I've compiled tkPath on macOS15 and here's reported warnings: ./macosx/tkMacOSXPath.c:113:50: warning: incompatible pointer types passing 'TkWindow *' (aka 'struct TkWindow *') to parameter of type 'Tk_Window' (aka 'struct Tk_Window_ *') [-Wincompatible-pointer-types] 113 | Tk_Window contWinPtr = Tk_GetOtherWindow(macWin->toplevel->winPtr); | ^~~~~~~~~~~~~~~~~~~~~~~~ ./macosx/tkMacOSXPath.c:244:24: warning: 'disableFlushWindow' is deprecated: first deprecated in macOS 10.14 - Use +[NSAnimationContext runAnimationGroup:completionHandler:] to perform atomic updates across runloop invocations. [-Wdeprecated-declarations] 244 | [[view window] disableFlushWindow]; | ^ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSWindow.h:1010:1: note: 'disableFlushWindow' has been explicitly marked deprecated here 1010 | - (void)disableFlushWindow API_DEPRECATED("Use +[NSAnimationContext runAnimationGroup:completionHandler:] to perform atomic updates across runloop invocations.", macos(10.0,10.14)); | ^ ./macosx/tkMacOSXPath.c:247:53: warning: 'graphicsPort' is deprecated: first deprecated in macOS 10.14 [-Wdeprecated-declarations] 247 | context->c = (CGContextRef)[currentGraphicsContext graphicsPort]; | ^~~~~~~~~~~~ | CGContext /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphicsContext.h:107:28: note: property 'graphicsPort' is declared deprecated here 107 | @property (readonly) void *graphicsPort NS_RETURNS_INNER_POINTER API_DEPRECATED_WITH_REPLACEMENT("CGContext", macos(10.0,10.14)); | ^ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphicsContext.h:107:28: note: 'graphicsPort' has been explicitly marked deprecated here ./macosx/tkMacOSXPath.c:295:30: warning: 'enableFlushWindow' is deprecated: first deprecated in macOS 10.14 - Use +[NSAnimationContext runAnimationGroup:completionHandler:] to perform atomic updates across runloop invocations. [-Wdeprecated-declarations] 295 | [[context->view window] enableFlushWindow]; | ^ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSWindow.h:1011:1: note: 'enableFlushWindow' has been explicitly marked deprecated here 1011 | - (void)enableFlushWindow API_DEPRECATED("Use +[NSAnimationContext runAnimationGroup:completionHandler:] to perform atomic updates across runloop invocations.", macos(10.0,10.14)); | ^ 4 warnings generated. should I open a ticket on gitHub? best regards, nicolas Le jeu. 26 juin 2025 à 05:06, apnmbx-public--- via Tcl-Core <tcl...@li... <mailto:tcl...@li...> > a écrit : Thanks Paul. I overlooked checking the demos. Committed a fix and they should be working now. Verified 9.0 and 8.6 with Ubuntu and 9.0 with VC++. Missed a structure field initializer during the merge though I’m not sure why it only impacted 9.0 and not 8.6. Also, I noticed the TkPathItemType and TkPathCanvas structure no longer match the corresponding types in Tk. I presume that is ok since they are only used internally. Hope someone will look at macos errors. /Ashok From: Paul Obermeier <pa...@po... <mailto:pa...@po...> > Sent: Thursday, June 26, 2025 1:22 AM To: tcl...@li... <mailto:tcl...@li...> Subject: Re: [TCLCORE] TkPath 0.4.1 Thanks Ashok for caring. I tested the tcltk-depot version on Windows (gcc), several Linux distros, Raspi and RiscV using Tcl/Tk 8.6.16 and 9.0.1. With the exception of MacOS the test suite runs without errors. On MacOS 15.5 there is 1 test suite error (both using 8.6.16 and 9.0.1), see below. The demos work fine using 8.6.16, but do not work using 9.0.1. I created issues for the 2 MacOS problems in case one of the Mac gurus wants to take a closer look. Regards, Paul Am 25.06.2025 um 17:30 schrieb apnmbx-public--- via Tcl-Core: https://github.com/tcltk-depot/tkpath now (purportedly) holds the merge of all the tkpath forks, versioned 0.4.1. There were more diffs w.r.t. Paul’s 0.4.0 than I expected so it would be nice if someone reviewed the merge. I’ve run the test suite on Windows 64 (VC++) and Ubuntu 20 (WSL). Volunteer needed to test on macOS (at least) and confirm. I do not plan further work on it myself. /Ashok From: Paul Obermeier <mailto:pa...@po...> <pa...@po...> Sent: Thursday, June 19, 2025 12:55 AM To: apn...@ya... <mailto:apn...@ya...> ; tcl...@li... <mailto:tcl...@li...> Subject: Re: [TCLCORE] tclx, tktreectrl and tkpath repositories and a request Some history. I originally had Rene's tkpath version in BAWT (last update was in 2018), which does not compile on Mac. Manfred Rosenberger (author of tkpath based RattleCAD) asked me to add Christian Werner's version of tkpath, because his version runs on Mac and has several other fixes. After Tcl9 release Steve Shaw sent me a Tcl9 ready version of tkpath. Unfortunately this version was based on Rene's version (no Mac) and did only work with Tcl9, but not Tcl8. I then merged the Tcl9 changes into Christian's version, which is the version 0.4.0 available with BAWT. So in my point of view, the BAWT version is the most advanced one. It runs the test suite without errors on Windows and Linux using Tcl/Tk 8.6.16 and Tcl/Tk 9.0.1 The test suite runs on Mac with 1 error both using Tcl/Tk 8.6.16 and 9.0.1, see below. Paul ==== canvText-1.12 configuration options: bad value for -stipple FAILED ==== Contents of test case: .c create text 20 20 -tag test .c itemconfigure test $name $badValue ---- Test completed normally; Return code was: 0 ---- Return code should have been one of: 1 ==== canvText-1.12 FAILED Am 18.06.2025 um 05:26 schrieb apnmbx-public--- via Tcl-Core: Thanks Paul. Do you know if your version of tkpath also incorporates Rene’s changes from chiselapp? I hope someone picks up tkpath, else I will make an attempt at a merge at some point. For the macOS issues, I’m afraid I have no way of testing GUI’s. At least for console only, Github actions can be used (painfully). /Ashok From: Paul Obermeier <mailto:pa...@po...> <pa...@po...> I do have a version of tkpath, which is a merge of Christian's and Steve's work and compiles using Tcl 8.6 and 9.0 on Windows, Linux and Mac. See https://www.bawt.tcl3d.org/download/InputLibs/tkpath-0.4.0.7z It works on Windows and Linux using Tcl 8.6 and 9.0. It works on Mac using 8.6, but does not work with Tcl 9.0. tktreectrl and tkpath have been tested on Windows and Linux. Someone testing on macOS would be helpful. Repository version of tktreectrl works on Windows, Linux, Mac using Tcl 8.6 and 9.0. Note, that I tested the packages only by using the simple scripts contained in the BAWT framework. _______________________________________________ Tcl-Core mailing list Tcl...@li... <mailto:Tcl...@li...> https://lists.sourceforge.net/lists/listinfo/tcl-core _______________________________________________ Tcl-Core mailing list Tcl...@li... <mailto:Tcl...@li...> https://lists.sourceforge.net/lists/listinfo/tcl-core _______________________________________________ Tcl-Core mailing list Tcl...@li... <mailto:Tcl...@li...> https://lists.sourceforge.net/lists/listinfo/tcl-core |