From: Jan N. <jan...@gm...> - 2025-05-08 11:22:55
|
Op do 8 mei 2025 om 11:56 schreef Ashok Nadkarni: > In fact, by that logic, there really is no need for 717 and Tcl_AttemptHashEntry at all. You can just change Tcl_CreateHashEntry semantics to allow NULL returns. Callers that check can take appropriate action and those that don't will crash instead of panic'ing. But the "shit already happened" so how does it matter 🙂 At least TIP #717 gives much better panic messages, especially with -DTCL_MEM_DEBUG. Did you note that? > Having said all that, this does not change my vote on 717 because of the (a) above - it will only happen for the case I laid out, not for an extension built against 9.1. I didn't see your vote yet. Regards, Jan Nijtmans |