Re: [TCLCORE] TIP 716 ready for comments

[Jan N. <jan...@gm...>]

Op ma 14 apr 2025 om 06:52 schreef Ashok:
>
> TIP 716: New command "encoding user", remove UTF-8 manifest setting on Windows is ready for comments. It proposes reversion of a change made in 9.0 to tclsh and wish Windows manifests while keeping compatibility with 9.0.{0,1}.

Let me share two more reservations on the TIP text:
1) Two times in the TIP, "MingW msvcrt" builds are mentioned as
    behaving differently from ucrt builds. Quoting:
        "The key difference with respect to the current implementation
issue that this does not impact extensions that call GetACP solving
the first issue listed above, or using MingW msvcrt builds."
    "An example is components built with MingW64 gcc using the msvcrt runtime"

    This is not correct. I did test that (see ticket
           https://core.tcl-lang.org/tcl/tktview/8ffd8cabd1)
     which was done using a MingW msvcrt build. The
     The GetACP() function functions exactly the same.
     There is an issue mixing different runtimes, but that's
     related to using stdin/stdout: different runtimes each
     have their own FILE implementation. So, opening
     a FILE in an extension using UCRT and writing it
     from other extension using MSVCRT is expected
     to crash. My suggestion: remove it from the TIP
     text (or provide a testcase proving your point, I
     will be happy to try it in my environment)

2) There is no usecase for exporting Tcl_GetEncodingNameForUser()
     I tried to use it, but the way it is now it's a bad idea. I am
     thinking about a separate TIP for a more useful approach.
     Stay tuned.

The reason I suspect that you didn't do any tests in the
MinGW msvcrt environment is that compilation in this
environment failed:
    <https://github.com/tcltk/tcl/actions/runs/14725688360>
I corrected that here, as a free service ;-)
     <https://core.tcl-lang.org/tcl/info/479fc6ad0dff8cdd>

Hope this helps,
          Jan Nijtmans