[TCLCORE] Bad test(1) evaluation in some packages.

[Bch <be...@sh...>]

>  I've run into cases where test(1) is misusing "==" to test for
>  equality. The proper format is "=". Attached find a patch applied
>  againts Sqlite as shipping in rc2, but I've seen this in other
>  extensions too. From my findings with *b3*:


Hello Don -- see my transciption below -- I think Sqlite might be
the only pkg affected, but for me its still in error.


$ ./retr
URL:           https://prdownloads.sourceforge.net/tcl/tcl9.0.0rc3-src.tar.gz
Effective URL: https://cfhcable.dl.sourceforge.net/project/tcl/Tcl/9.0.0/tcl9.0.0rc3-src.tar.gz?viasf=1
File out:      tcl9.0.0rc3-src.tar.gz
SHA1:          0c917d8a56fbc3f590c12a08355e3e2b669bb01c
SHA2:          af853da10817b947b9b8caf859e691b0cd849e4f8e45c5a44577c5ed10c4e962
katy$ find . -type f  | xargs grep "if test.*=="
./tcl9.0.0/pkgs/sqlite3.45.3/configure:    if test "${TCL_MAJOR_VERSION}" -gt 8 -a x"${with_tcl8}" == x; then
./tcl9.0.0/pkgs/sqlite3.45.3/configure: if test "${TCL_MAJOR_VERSION}" -gt 8 -a x"${with_tcl8}" == x; then
./tcl9.0.0/pkgs/sqlite3.45.3/configure: if test "${TCL_MAJOR_VERSION}" -gt 8 -a x"${with_tcl8}" == x; then




Index: pkgs/sqlite3.45.3/configure
==================================================================
--- pkgs/sqlite3.45.3/configure
+++ pkgs/sqlite3.45.3/configure
@@ -9561,11 +9561,11 @@
     # substituted. (@@@ Might not be necessary anymore)
     #--------------------------------------------------------------------
 
     PACKAGE_LIB_PREFIX8="${PACKAGE_LIB_PREFIX}"
     PACKAGE_LIB_PREFIX9="${PACKAGE_LIB_PREFIX}tcl9"
-    if test "${TCL_MAJOR_VERSION}" -gt 8 -a x"${with_tcl8}" == x; then
+    if test "${TCL_MAJOR_VERSION}" -gt 8 -a x"${with_tcl8}" = x; then
 	PACKAGE_LIB_PREFIX="${PACKAGE_LIB_PREFIX9}"
     else
 	PACKAGE_LIB_PREFIX="${PACKAGE_LIB_PREFIX8}"
 
 printf "%s\n" "#define TCL_MAJOR_VERSION 8" >>confdefs.h
@@ -9592,11 +9592,11 @@
 	    eval eval "PKG_LIB_FILE8=${PACKAGE_LIB_PREFIX8}${PACKAGE_NAME}${UNSHARED_LIB_SUFFIX}"
 	    eval eval "PKG_LIB_FILE9=${PACKAGE_LIB_PREFIX9}${PACKAGE_NAME}${UNSHARED_LIB_SUFFIX}"
 	    eval eval "PKG_LIB_FILE=${PACKAGE_LIB_PREFIX}${PACKAGE_NAME}${UNSHARED_LIB_SUFFIX}"
 	fi
 	# Some packages build their own stubs libraries
-	if test "${TCL_MAJOR_VERSION}" -gt 8 -a x"${with_tcl8}" == x; then
+	if test "${TCL_MAJOR_VERSION}" -gt 8 -a x"${with_tcl8}" = x; then
 	    eval eval "PKG_STUB_LIB_FILE=${PACKAGE_LIB_PREFIX8}${PACKAGE_NAME}stub.a"
 	else
 	    eval eval "PKG_STUB_LIB_FILE=${PACKAGE_LIB_PREFIX8}${PACKAGE_NAME}stub${UNSHARED_LIB_SUFFIX}"
 	fi
 	if test "$GCC" = "yes"; then
@@ -9620,11 +9620,11 @@
 	    eval eval "PKG_LIB_FILE8=lib${PACKAGE_LIB_PREFIX8}${PACKAGE_NAME}${UNSHARED_LIB_SUFFIX}"
 	    eval eval "PKG_LIB_FILE9=lib${PACKAGE_LIB_PREFIX9}${PACKAGE_NAME}${UNSHARED_LIB_SUFFIX}"
 	    eval eval "PKG_LIB_FILE=lib${PACKAGE_LIB_PREFIX}${PACKAGE_NAME}${UNSHARED_LIB_SUFFIX}"
 	fi
 	# Some packages build their own stubs libraries
-	if test "${TCL_MAJOR_VERSION}" -gt 8 -a x"${with_tcl8}" == x; then
+	if test "${TCL_MAJOR_VERSION}" -gt 8 -a x"${with_tcl8}" = x; then
 	    eval eval "PKG_STUB_LIB_FILE=lib${PACKAGE_LIB_PREFIX8}${PACKAGE_NAME}stub.a"
 	else
 	    eval eval "PKG_STUB_LIB_FILE=lib${PACKAGE_LIB_PREFIX8}${PACKAGE_NAME}stub${UNSHARED_LIB_SUFFIX}"
 	fi
     fi