From: Francois V. <fvo...@fr...> - 2024-09-09 20:20:11
|
Le 09/09/2024 à 09:53, elns a écrit : > On 9/9/24 09:38, Harald Oehlmann wrote: >> I did not get where the issue is. We have a good fix. >> Is the mentioning in the changes file ok? > I wouldn't do anything before knowing the opinion of Francois, in this > case. The changes introduced by the ticket in question are the following (consolidated) ones: https://core.tcl-lang.org/tk/vdiff?from=71f581f3e731e7c2&to=3cc37438bb772ef2 They modify the behavior of the binding mechanism by no longer discarding <Enter> or <Leave> events having LeaveNotify or NotifyInferior detail field. Tk did this since the beginning of time, or almost, for an obscure reason linked to megawidgets that I finally have dug out (see discussion in the ticket) here: https://core.tcl-lang.org/tk/artifact/b3340eb2?ln=2079,2085 And this old behavior was undocumented. So the change made by this ticket is a rather obscure thing, and the ancestral behavior of Tk probably never found a use case for it. But to be on the safe side one can add a *** POTENTIAL INCOMPATIBILITY *** line in the changes file. Finally, if anyone is not comfortable in having this change in a patch release, then just revert it and keep it in trunk (9.0) only, that's also possible. Note however that this was discussed in the ticket, that we first decided to merge in trunk only (with Csaba's positive tests with Tablelist, Mentry and Scrollutil packages). Then Erik brought reasons to include the fix in core-8-6-branch, which was done. > Nevertheless, Csaba Nemethi made adaptations to one of his packages > because of this fix. I would be interested to know what had to be adapted here (especially considering that Csaba tested the changes before we merged). Regards, Francois |