Menu
▾
▴
Re: [TCLCORE] [Tcl-bugs] [Tk] (jan.nijtmans) com (revised_text): Is this assert correct? And we are (for now) only interested in --disable-aqua builds
|
From: Francois V. <fvo...@fr...> - 2024-09-04 21:11:54
|
Hi Jan, I see you changed the assert condition in the commit below. Maybe you're right. I agree the code in TkTextIndexCountBytes() seems to only require that the two indices arguments only need to be ordered and the equality case seems to be handled, so that your change in the assert should be okay, but: - How do you explain this assert triggered only for the macOS --disable-aqua CI runner and not with any other platform runner, whereas this assert is in generic code? - How come that this assert triggers today at CI but not yesterday? I cannot reproduce this assert triggering on Windows, and neither on macOS with XQuartz (the same configuration as at CI!). Without being comfortable answering the above questions and having an understanding I wouldn't have changed anything in the code. I hope you can explain. Regarding your quest for which tests triggers the BadValue error, I can reproduce on the mac with XQuartz (don't you?): ---- textIndex-19.14 start X Error of failed request: BadValue (integer parameter out of range for operation) Major opcode of failed request: 45 (X_OpenFont) Value in failed request: 0xa000a7 Serial number of failed request: 1364 Current serial number in output stream: 1365 Finally, no, I'm still interested by xcode builds. Regards, Francois Le 04/09/2024 à 16:07, no...@tc... a écrit : > Automated mail by fx, on behalf of no...@tc... > > Commit [e27c4627670e0ec1abfb6f31e791b081b20ef454753c6010c6c5b281d4834642] > By jan.nijtmans > For Tk (branch: revised_text) > On 2024-09-04T14:07:00.429 > Details https://core.tcl-lang.org/tk/info/e27c4627670e0ec1abfb6f31e791b081b20ef454753c6010c6c5b281d4834642 > > Description > Is this assert correct? And we are (for now) only interested in > --disable-aqua builds > > Changed Files > 2 edited > .github/workflows/mac-build.yml > generic/tkTextIndex.c > > ------------------------------------------------------------ > See Tcl/Tk development @ http://core.tcl-lang.org/ > ------------------------------------------------------------ > > > _______________________________________________ > Tcl-Bugs mailing list > Tcl...@li... > https://lists.sourceforge.net/lists/listinfo/tcl-bugs |
