Re: [TCLCORE] Tcl/Tk 8.6.10 Release Candidates

[Marc C. <cul...@gm...>]

If no one objects I would like to merge the catalina_more_tests branch into
core-8-6-branch and close it.  The changes would be:

UPDATE macosx/tkMacOSXColor.c
UPDATE macosx/tkMacOSXNotify.c
UPDATE tests/ttk/entry.test

I am not sure why the last one was not merged earlier, but I see no problem
with doing that.

- Marc


On Thu, Oct 10, 2019 at 3:51 AM Jan Nijtmans <jan...@gm...> wrote:

> Op do 10 okt. 2019 om 01:27 schreef Marc Culler:
> > I ran the test suite on VMs running Sierra, High Sierra, and Mojave as
> well as on real hardware running Catalina.  I got:
> >
> > Sierra - 1 failure:  image-11.1, as expected
> > High Sierra - 1 failure: image-11.1, as expected
> > Mojave - 0 failures
> > Catalina - 0 failures
>
> Great progress!  I backported the test-case changes (with some more
> tweaks) back to core-8-6-branch, so more
> people can verify that everything is correct on other platforms too.
> Hopefully I didn't break any test-cases on
> Catalina with that, didn't verify that yet ...
>
> On Windows (Windows 10, build 17763), currently I see 6 test failures
> in Tk. They are present
> for a long time, so nothing to worry about, but anyway here they are:
>
> ==== bind-34.1 -warp works relatively to a window FAILED
> ==== Contents of test case:
>
>     # In order to avoid platform-dependent coordinate results due to
>     # decorations and borders, this test warps the pointer twice
>     # relatively to a window that moved in the meantime, and checks
>     # how much the pointer moved
>     wm geometry .top +200+200
>     update
>     event generate .top <Motion> -x 20 -y 20 -warp 1
>     update idletasks ; # DoWarp is an idle callback
>     set pointerPos1 [winfo pointerxy .t]
>     wm geometry .top +600+600
>     update
>     event generate .top <Motion> -x 20 -y 20 -warp 1
>     update idletasks ; # DoWarp is an idle callback
>     set pointerPos2 [winfo pointerxy .t]
>     # from the first warped position to the second one, the mouse
>     # pointer should have moved the same amount as the window moved
>     set res 1
>     foreach pos1 $pointerPos1 pos2 $pointerPos2 {
>         if {$pos1 != [expr {$pos2 - 400}]} {
>             set res 0
>         }
>     }
>     set res
>
> ---- Result was:
> 0
> ---- Result should have been (exact matching):
> 1
> ==== bind-34.1 FAILED
> ==== canvText-20.1 angled text bounding box FAILED
> ==== Contents of test case:
>
>     .c create text 2 2 -tag t -anchor center -text 0 -font {Helvetica 24}
>     set bb0 [.c bbox t]
>     .c itemconf t -angle 90
>     set bb1 [.c bbox t]
>     .c itemconf t -angle 180
>     set bb2 [.c bbox t]
>     .c itemconf t -angle 270
>     set bb3 [.c bbox t]
>     list [expr {$bb0 eq $bb2 ? "ok" : "$bb0,$bb2"}]  [expr {$bb1 eq
> $bb3 ? "ok" : "$bb1,$bb3"}]  [expr {$bb0 eq [transpose $bb1] ? "ok" :
> "$bb0,$bb1"}]
> ---- Result was:
> {-10 -20 14 25,-10 -21 14 24} {-20 -10 25 14,-21 -10 24 14} ok
> ---- Result should have been (exact matching):
> ok ok ok
> ==== canvText-20.1 FAILED
>
> ==== frame-2.8 toplevel configuration options FAILED
> ==== Contents of test case:
>
>     catch {destroy .t}
>     toplevel .t -width 200 -height 100
>     wm geometry .t +0+0
>     .t configure -use 0x44022
>
> ---- Result was:
> can't modify -use option after widget is created
> ---- Result should have been (exact matching):
> window "0x44022" doesn't exist
> ==== frame-2.8 FAILED
> ==== frame-12.3 FrameWorldChanged procedure FAILED
> ==== Contents of test case:
>
>     # Check reaction on font change
>     font create myfont -family courier -size 10
>     labelframe .f -font myfont -text Mupp
>     place .f -x 0 -y 0 -width 40 -height 40
>     pack [frame .f.f] -fill both -expand 1
>     update
>     set h1 [font metrics myfont -linespace]
>     set y1 [winfo y .f.f]
>     font configure myfont -size 20
>     update
>     set h2 [font metrics myfont -linespace]
>     set y2 [winfo y .f.f]
>     expr {($h2 - $h1) - ($y2 - $y1)}
>
> ---- Result was:
> 16
> ---- Result should have been (exact matching):
> 0
> ==== frame-12.3 FAILED
>
>
> ==== scrollbar-6.27 ScrollbarPosition procedure FAILED
> ==== Contents of test case:
>
>     .s identify [expr {[winfo width .s] / 2}] [expr {int(.4 / [.s delta 0
> 1])
>                                                  + [testmetrics cyvscroll
> .s]}]
>
> ---- Result was:
> slider
> ---- Result should have been (exact matching):
> trough2
> ==== scrollbar-6.27 FAILED
>
>
> ==== winWm-5.1 UpdateGeometryInfo: menu resizing FAILED
> ==== Contents of test case:
>
>     toplevel .t
>     frame .t.f -width 150 -height 50 -background red
>     pack .t.f
>     update
>     set result [winfo height .t]
>     menu .t.m
>     .t.m add command -label foo
>     .t configure -menu .t.m
>     update
>     lappend result [winfo height .t]
>     .t.m add command -label "thisisreallylong"
>     .t.m add command -label "thisisreallylong"
>     update
>     lappend result [winfo height .t]
>
> ---- Result was:
> 50 50 2
> ---- Result should have been (exact matching):
> 50 50 31
> ==== winWm-5.1 FAILED
>
> Regards,
>        Jan Nijtmans
>
>
> _______________________________________________
> Tcl-Core mailing list
> Tcl...@li...
> https://lists.sourceforge.net/lists/listinfo/tcl-core
>