|
From: Brad L. <bra...@gm...> - 2019-10-09 20:47:39
|
On Wed, Oct 9, 2019 at 12:55 PM Marc Culler <cul...@gm...> wrote: > When I looked at textDisp.test I was shocked at the overuse of the update > command, especially given that our own wiki > <https://wiki.tcl-lang.org/page/update> strongly advises against using > it. I mean, really, what are you testing when you need to use commands like > update ; update ; update > and how exactly is that different from > update ; update ; update ; update > ? > I think many of the tests do need an update call, as they must wait for something to be drawn or for an event to be processed. Whereas the wiki is mostly correct, I don't think it applies to testing. If the test needs a delay, it should be coded something like: set ::x 0 after 200 set ::x 1 vwait ::x update In your recent checkin, Marc, can the 0.25 seconds be changed to 0.1 seconds. 0.25 seconds can be noticeable, and I find 0.1 seconds works well when I need a no-cpu delay. |