Re: [TCLCORE] Tcl 8.6.9 Release Candidate

[Harald O. <har...@el...>]

As far as I remember, we have already tried that at the time before.

The test still fails. Here is the log. I have put a comment mark in
front of the new line.

==== textTag-18.1 TkTextPickCurrent tag bindings FAILED
==== Contents of test case:

    text .t -width 30 -height 4 -relief sunken -borderwidth 10
-highlightthickness 10 -pady 2
    pack .t
    # update ; # map the window, otherwise -warp can't be done

    .t insert end " Tag here " TAG " no tag here"
    .t tag configure TAG -borderwidth 4 -relief raised
    .t tag bind TAG <Enter>  {lappend res "%x %y tag-Enter"}
    .t tag bind TAG <Leave>  {lappend res "%x %y tag-Leave"}
    bind .t <Enter> {lappend res Enter}
    bind .t <Leave> {lappend res Leave}

    set res {}
    # Bindings must not trigger on the widget border, only over
    # the actual tagged characters themselves.
    event gen .t <Motion> -warp 1 -x 0 -y 0 ; update
    event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
    event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
    event gen .t <Motion> -warp 1 -x 20 -y 20 ; update
    event gen .t <Motion> -warp 1 -x 10 -y 10 ; update
    event gen .t <Motion> -warp 1 -x 25 -y 25 ; update
    return $res

---- Result was:
{25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
---- Result should have been (exact matching):
Enter {25 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter}
==== textTag-18.1 FAILED

Harald


Am 14.10.2018 um 18:45 schrieb Francois Vogel:
> Le 14/10/2018 à 18:14, Harald Oehlmann a écrit :
>> I just rechecked 8.6.8 with my current system (Win 10 1803). The failure
>> is still identically there. The test log is identical to (I suppose it
>> was Win10 1703).
>> So, it should be a Tk change between 8.6.8 and 8.6.9a0.
> 
> Very interesting. Can you then, on your Win10 1803, with Tcl/Tk 8.6.9 rc0:
> 
>     1.  remove this checking [745b43440b2cbe03] I already mentioned
> (which was suppoed to fix the case of macOS), i.e. apply the following
> patch:
> 
> Index: tests/textTag.test
> ==================================================================
> --- tests/textTag.test
> +++ tests/textTag.test
> @@ -1744,10 +1744,11 @@
>      event generate {} <Motion> -warp 1 -x -1 -y -1; update
>  } -body {
>      text .t -width 30 -height 4 -relief sunken -borderwidth 10 \
>        -highlightthickness 10 -pady 2
>      pack .t
> -    update ; # map the window, otherwise -warp can't be done
>           .t insert end " Tag here " TAG " no tag here"
>      .t tag configure TAG -borderwidth 4 -relief raised
>      .t tag bind TAG <Enter>  {lappend res "%x %y tag-Enter"}
>      .t tag bind TAG <Leave>  {lappend res "%x %y tag-Leave"}
> 
> 
> and
> 
>     2. Test again textTag-18.1
> 
> Does it fail? I bet it does.
> 
> If so, the problem I have with this is that it does not fully sleep with
> Ashok's analysis.
> 
> Thanks,