Re: [TCLCORE] Tcl / Tk 8.6.8 Release Candidates

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

A search through this checkin

http://core.tcl.tk/tdbcodbc/info/30d9cacca17c347f

makes clear that the TIP 477 work resulted in the loss of a

-Dinline=__inline

Restoring it in PRJ_DEFINES makes as much sense to me as anything, and 
has the benefit of being tested.

I will make that change.

If there's a better approach we should use instead, we can move to it in 
the next release.

DGP

On 12/21/2017 12:59 PM, Harald Oehlmann wrote:
> Sergey,
> thank you for the message.
> 
> I have found:
> PRJ_DEFINES	= -DTCL_TOMMATH -DMP_PREC=4 -Dinline=__inline -DHAVE_ZLIB=1
> -D_CRT_SECURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE
> in line 356 of win/makefile.vc
> 
> if I insert:
> PRJ_DEFINES		= -Dinline=__inline
> as line 73 of pkgs/tdbcodbc1.0.6/win/Makefile.vc
> 
> all compiles fine.
> 
> So, this might be a good patch...
> 
> Unfortunately, it is night time in India, so Ashok may only comment in
> some hours...
> 
> Thank you,
> Harald
> 
> 
> 
> Am 21.12.2017 um 18:34 schrieb Dipl. Ing. Sergey G. Brester:
>> Hi Harald,
>>
>> in VS "inline" is normally for C++ only, for C it can be defined like:
>>
>> nmake -nologo -f makefile.vc TCLDIR=%TCLDIR% OPTS=...
>> OPTDEFINES="*-Dinline=__inline*"
>>
>> No idea which parameter exactly can be used to extend options from
>> command-line by tdbcodbc (OPTDEFINES, ADDOPTDEFINES, OPTIMIZATIONS, etc.)...
>> Just take a look in rules.vc resp. makefile.vc for it...
>>
>> Regards,
>> Sergey.
>>
>> Am 21.12.2017 18:16, schrieb Harald Oehlmann:
>>
>>> Dear folks,
>>>
>>> I think I have overlooked an issue.
>>>
>>> Here is a compilation error in tdbcodbc.c
>>>
>>> tdbcodbc.c
>>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1009) :
>>> error C2054: expected '(' to follow 'inline'
>>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) :
>>> error C2082: redefinition of formal parameter 'LookupOdbcType'
>>> C:\test\tcl8.6.8\pkgs\tdbcodbc1.0.6\win\..\generic\tdbcodbc.c(1013) :
>>> error C2143: syntax error : missing ';' before '{'
>>>
>>> This is MSVC 6++ win32 compilation. There is normally a macro which uses
>>> "_inline", as the inline keyword does not exist on MSVC6.
>>>
>>> Thank you,
>>> Harald
>>>
>>>
>>> Am 21.12.2017 um 16:40 schrieb Harald Oehlmann:
>>>> Dear Donald, big christmas present to the community ! Now it compiles
>>>> well. Here are the test differences compared to tcl 8.6.7, details
>>>> below: New failures: Tk: imgPNG-3.1, textTag-18.1 Still failing: Tcl:
>>>> cmdAH-25.3.1 fCmd-9.9 fCmd-9.11 iortrans-11.1 iortrans-11.2
>>>> winFCmd-2.8 iTCL: sfbug-254 sfbug-257 Tk: winfont-2.7 winfont-2.8
>>>> winfont-2.9 Thank you, great ! Harald -- Details -- ==== imgPNG-3.1
>>>> reading image with unknown ancillary chunk - bug [1c659ef0f1] FAILED
>>>> ==== Contents of test case: # the image contains an unknown chunk
>>>> iDOT # since the name of this chunk starts with a lowercase letter, #
>>>> it's an ancillary chunk that shall not trigger an error catch {set i
>>>> [image create photo -file $fileName]} ---- Result was: 1 ---- Result
>>>> should have been (exact matching): 0 ---- Test cleanup failed: image
>>>> "image19" doesn't exist ---- errorInfo(cleanup): image "image19"
>>>> doesn't exist while executing "image delete $i" ("uplevel" body line
>>>> 2) invoked from within "uplevel 1 $cleanup" ---- errorCode(cleanup):
>>>> TK LOOKUP IMAGE image19 ==== imgPNG-3.1 FAILED ==== textTag-18.1
>>>> TkTextPickCurrent tag bindings FAILED ==== Contents of test case:
>>>> text .t -width 30 -height 4 -relief sunken -borderwidth 10
>>>> -highlightthickness 10 -pady 2 pack .t .t insert end " Tag here " TAG
>>>> " no tag here" .t tag configure TAG -borderwidth 4 -relief raised .t
>>>> tag bind TAG <Enter> {lappend res "%x %y tag-Enter"} .t tag bind TAG
>>>> <Leave> {lappend res "%x %y tag-Leave"} bind .t <Enter> {lappend res
>>>> Enter} bind .t <Leave> {lappend res Leave} set res {} # Bindings must
>>>> not trigger on the widget border, only over # the actual tagged
>>>> characters themselves. event gen .t <Motion> -warp 1 -x 0 -y 0 ;
>>>> update event gen .t <Motion> -warp 1 -x 10 -y 10 ; update event gen
>>>> .t <Motion> -warp 1 -x 25 -y 25 ; update event gen .t <Motion> -warp
>>>> 1 -x 20 -y 20 ; update event gen .t <Motion> -warp 1 -x 10 -y 10 ;
>>>> update event gen .t <Motion> -warp 1 -x 25 -y 25 ; update return $res
>>>> ---- Result was: {25 25 tag-Enter} {20 20 tag-Leave} {25 25
>>>> tag-Enter} ---- Result should have been (exact matching): Enter {25
>>>> 25 tag-Enter} {20 20 tag-Leave} {25 25 tag-Enter} ==== textTag-18.1
>>>> FAILED
>>>> ------------------------------------------------------------------------------
>>>> Check out the vibrant tech community on one of the world's most
>>>> engaging tech sites, Slashdot.org! https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsdm.link%2Fslashdot&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=Bb%2BDHvUgoVmWSCQidc6%2BayUmZnHTAbowyKzgzanNtYY%3D&reserved=0
>>>> _______________________________________________ Tcl-Core mailing list
>>>> Tcl...@li...
>>>> <mailto:Tcl...@li...>
>>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.sourceforge.net%2Flists%2Flistinfo%2Ftcl-core&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=CHUMRtsnIZpKdybs5u1xmnnRFRgLKY5zOM7n3%2FUBRmU%3D&reserved=0
>>> -- 
>>> ELMICRON Dr. Harald Oehlmann GmbH
>>> Koesener Str. 85
>>> 06618 NAUMBURG - Germany
>>> Phone: +49 (0)3445 78112-0
>>> Fax: +49 (0)3445 78112-19
>>> https://na01.safelinks.protection.outlook.com/?url=www.Elmicron.de&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=hWyvhioMCUHW2KK20f78HRq19RgS1ea9sXGwma%2FdUQ0%3D&reserved=0 <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.Elmicron.de&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=xHokt3rwVaLuP%2F1QzUOonxB%2Bu24eH518pQTyUqQc2tk%3D&reserved=0>
>>> German legal references:
>>> Geschaeftsfuehrer: Dr. Harald Oehlmann, Jens Oehlmann
>>> UST Nr. / VAT ID No.: DE206105272
>>> HRB 212803 Stendal
>>>
>>> ------------------------------------------------------------------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsdm.link%2Fslashdot&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=Bb%2BDHvUgoVmWSCQidc6%2BayUmZnHTAbowyKzgzanNtYY%3D&reserved=0
>>> _______________________________________________
>>> Tcl-Core mailing list
>>> Tcl...@li... <mailto:Tcl...@li...>
>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.sourceforge.net%2Flists%2Flistinfo%2Ftcl-core&data=02%7C01%7Cdonald.porter%40nist.gov%7Cd898d681419e412c3e0508d5489cc64e%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C1%7C636494760553682109&sdata=CHUMRtsnIZpKdybs5u1xmnnRFRgLKY5zOM7n3%2FUBRmU%3D&reserved=0
> 
> 

-- 
| Don Porter            Applied and Computational Mathematics Division |
| don...@ni...             Information Technology Laboratory |
| http://math.nist.gov/~DPorter/                                  NIST |
|______________________________________________________________________|

Re: [TCLCORE] Tcl / Tk 8.6.8 Release Candidates

The Tool Command Language implementation

Re: [TCLCORE] Tcl / Tk 8.6.8 Release Candidates