[MACTCL] HITheme buttons committed; scrolling deferred for now

[Kevin W. <kw...@co...>]

Hello all,

I've committed my changes to Tk-Cocoa's button code into trunk and 
core-8-5-branch, switching from Cocoa (NSButton) to an HITheme-based 
implementation. I've done a lot of testing them with the Wish demo, with 
various client apps using Tk, and some hard cases that were triggering 
the serious bugs we were seeing with the previous implementation. The 
HITheme versions do not flicker or bleed through when a window is 
resized or window stackorder is changed. After some trial and error and 
refinement, they also look acceptable in terms of visual display, 
metrics, etc. Any differences are subtle and are not likely to present 
any issue.

I'm committing these now with the aim of getting them into the next 
point releases of Tk. I'm deferring scrolling. The existing 
Cocoa/NSScroller implementation works just fine but shows the same 
issues with flicker and bleeding, ghost images that the NSButton bits 
did. To my surprise, even creating a custom themed scrollbar for Tk/Mac 
is difficult because the Aqua ttk theme omits support for it. Thus, that 
approach is a dead end.

I'm going to continuing working with the HITheme scrolling 
implementation. I have studied the old Carbon implementation and am 
adding some more code from that (with appropriate translations for the 
new API's), and hopefully that will get me closer.

Thanks,
Kevin

-- 
Kevin Walzer
Code by Kevin/Mobile Code by Kevin
http://www.codebykevin.com
http://www.wtmobilesoftware.com