Re: [MACTCL] [TCLCORE] Clipboard copy crash with ActiveTcl 8.5.12?

[Kevin W. <kw...@co...>]

On 8/7/12 5:28 PM, Adrian Robert wrote:
> Here is a simple-minded patch that fixes it for me, and I can see no ill effects in an application running it.  However, I have no understanding of the context of what this code is doing, what harm it might do, or what change happened in the first place to start causing this though.
>
>
> --- tkMacOSXEmbed.c
> +++ tkMacOSXEmbed.c
> @@ -155,11 +155,11 @@
>   	     */
>
>   	    macWin->xOff = 0;
>   	    macWin->yOff = 0;
>   	    macWin->toplevel = macWin;
> -	} else {
> +	} else if (winPtr->parentPtr) {
>   	    macWin->xOff = winPtr->parentPtr->privatePtr->xOff +
>   		    winPtr->parentPtr->changes.border_width +
>   		    winPtr->changes.x;
>   	    macWin->yOff = winPtr->parentPtr->privatePtr->yOff +
>   		    winPtr->parentPtr->changes.border_width +
>

Thanks, I will check this out immediately.

For what it's worth, the crash also happens on trunk under OS X.

I have no idea where this bug came from; I've never touched this file.

--K
-- 
Kevin Walzer
Code by Kevin
http://www.codebykevin.com