Re: [TCLCORE] TIP #360: Modernize X11 Menus

[Pat T. <pat...@us...>]

Joe English <jen...@fl...> writes:

>Pat Thoyts wrote:
>>  TIP #360: MODERNIZE X11 MENUS
>
>This looks good - both the specification and the implementation.
>Initial feedback here and on the chat has been universally positive.
>I see no reason not to fast-track this.
>
>Notes and nits:
>
>Instead of new *Menu.useMotifHelp and *Menu.clickToFocus XRDB
>options, it might be better to just check Tk_StrictMotif() /
>$::tk_strictMotif instead.  No need to proliferate feechur options.

I'll disagree there. Setting tk_strictMotif makes some widespread
changes. For instance the tk_getOpenFile dialog switches to a version
that doesn't use ttk widgets. The reason I wanted to provide for
disabling the help menu position fix is that when I asked in the chat
about this I found that tkabber recently changed to make use of
this. They have some dynamic menu changes and wanted to stop the menu
bouncing about quite so much. Given that is a fairly small sample of Tk
users there are likely to be a number more that actively want to keep
this. But its not going to be helpful to roll that into a general 'use
Motif' flag.

>The patch at SourceForge does not update the "DEFAULT BINDINGS"
>section of the menu(3tk) manpage, which may now be out of date.

Yes - I pushed it early to get some testers.

>And a meta-note: I don't think this is the sort of change
>that ought to require a TIP.  I will certainly vote YES on this,
>but it could equally well be considered a bugfix.

I felt that it could do with a reasonably wide exposure to test the
amount of complaints raised. I never can tell when something will cause
a big commotion and making a TIP of the issue helps with this - everyone
can stick their oar in.

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD