Re: [TCLCORE] Patch: fix bug in Tk where X11 displays whose names contain "::" couldn't be used (plain text this time)

[Tristan S. <tri...@al...>]

Sorry for the delay. I tested your patch today Jan and it works. I
will open a bug.

On Mon, Dec 7, 2009 at 5:14 AM, Tristan Schmelcher
<tri...@al...> wrote:
> My patch should work fine with multiple "::" sequences actually
> (perhaps not if back-to-back), but your code is shorter. I'll test it
> later today.
>
> On Mon, Dec 7, 2009 at 11:18 AM, Jan Nijtmans
> <nij...@us...> wrote:
>> Good catch. In the past there was a bug-fix in clock.tcl, which simply
>> fixed this by escaping the problematic character. See:
>>  <http://tcl.cvs.sourceforge.net/viewvc/tcl/tcl/library/clock.tcl?r1=1.48&r2=1.49>
>>
>> Here I would fix it the same way. Your patch only handles a single "::", and
>> in fact the original code doesn't work well when the display name would
>> contain spaces (is that possible?). Anyway, here is a new patch, which
>> should work with colons as well as spaces in the display name.
>>
>> Could you please submit a bug report for this, and test the attached
>> patch?
>>
>> Regards,
>>         Jan Nijtmans
>>
>> 2009/12/6 Tristan Schmelcher <tri...@al...>:
>>> Hello,
>>>
>>> I recently discovered a bug in Tk with X11 display strings. If the
>>> display string contains "::" then Tk cannot load, because it uses the
>>> display name as a variable name and this produces an error about the
>>> parent namespace not being defined. This happened to me when trying to
>>> use a Tk app (Mentor Graphics ModelSim) over XVnc, where the display
>>> string was "::1:1.0". At least one other person has reported the same
>>> problem: http://ubuntu-ky.ubuntuforums.org/showthread.php?p=8255492.
>>> (That post suggests that this has only recently become a problem,
>>> probably because until now display names never contained "::".)
>>>
>>> I have attached a patch that fixes the bug. I have verified that it
>>> works in Tk 8.4, though for your convenience I have generated the patch
>>> against Tk 8.5. Please consider incorporating it.
>>>
>>> Thanks!
>>>
>>> (Sorry about the HTML email before ...)
>>>
>>> ------------------------------------------------------------------------------
>>> Join us December 9, 2009 for the Red Hat Virtual Experience,
>>> a free event focused on virtualization and cloud computing.
>>> Attend in-depth sessions from your desk. Your couch. Anywhere.
>>> http://p.sf.net/sfu/redhat-sfdev2dev
>>> _______________________________________________
>>> Tcl-Core mailing list
>>> Tcl...@li...
>>> https://lists.sourceforge.net/lists/listinfo/tcl-core
>>>
>>>
>>
>