[Tcl-bugs] [ tcl-Bugs-2529157 ] TclMakeEnsemble and NR-enabled subcommands

[SourceForge.net <no...@so...>]

Bugs item #2529157, was opened at 2009-01-22 18:54
Message generated for change (Settings changed) made by dkf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=2529157&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 21. [namespace]
Group: development: 8.6b1.1
>Status: Closed
>Resolution: Accepted
>Priority: 8
Private: No
Submitted By: Don Porter (dgp)
Assigned to: Donal K. Fellows (dkf)
Summary: TclMakeEnsemble and NR-enabled subcommands

Initial Comment:

In the NRE world, a Command no longer
needs a non-NULL objProc to be valid.
A non-NULL nreProc is also sufficient.

Starting at line 6220 of tclNamesp.c,
I suggest this alternative:

if (map[i].proc || map[i].nreProc) {
  cmdPtr = (Command *)Tcl_NRCreateCommand(interp,
      TclGetString(toObj), map[i].proc,
      map[i].nreProc, map[i].clientData, NULL);
  cmdPtr->compileProc = map[i].compileProc;
  if (map[i].compileProc != NULL)
    ensembleFlags |= ENSEMBLE_COMPILE;
}

With that change, the routine DictForCmd()
no longer needs to exist.  The NRE-enabled
version DictForNRCmd() is sufficient.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=2529157&group_id=10894