Re: [TCLCORE] TIP #330 and (void) Tcl_GetStringResult(interp) calls in the core

[Andreas K. <aku...@sh...>]

> Jan Nijtmans wrote:
> > In 7 places in the core I find calls like:
> >      (void) Tcl_GetStringResult(interp)

> > but interp->result is not used afterwards. I'm refering to
> > tclBasic.c (6) and tclHistory.c (1).

> > Shouldn't these calls have been removed as part of the TIP #330
> > implementation? If extensions are not allowed any more to access
> > interp->result directly, then those calss serve no purpose other
> > than slowing down Tcl. It might break extensions which still use
> > interp->result, but due to TIP #330, that's exactly what users of
> > Tcl 8.6 should expect.
 
> If we had made the Tcl_Interp data structure opaque in 8.5, I'd
> agree with you wholeheartedly.  We've moved too slowly on this, and
> been too quiet about the initial warnings.  Since we didn't vote to
> take out interp->result altogether, I'm a little nervous about
> taking out the code that makes it useful, particularly since there's
> not much field experience left (unless Andreas has reported
> something that I've missed) about what this does to currently
> fielded extensions. (He maintains the largest extension distribution
> that I'm aware of.) Andreas, have you tried building the AT
> extension set against 8.6-post-TIP#330?

My apologies for the delay. My win workstation in the office broke
down during the night (suspecting the motherboard) and the majority of
the day was spent getting myself running on a new box. No mail for
most of the day, and right now the shiny new Thunderbird is busy
importing mail from the old LookOut setup.

To the question:

The last AT 8.6 build was done last Sunday against the CVS head as of
Friday afternoon Pacific.

This failed completely. The culprit was an extension critical to the
build which had not been adapted to the missing 'interp->errorLine'
field (TIP #336) yet.

This has all been fixed now (including three more extensions with the
same problem, but not critical to the build) and the next 8.6 build is
this night, using the same Friday afternoon Tcl 8.6.


 
-- 
So long,
	Andreas Kupries <aku...@sh...>
			<http://www.purl.org/NET/akupries/>
	Developer @	<http://www.activestate.com/>
-------------------------------------------------------------------------------