Re: [TCLCORE] TIP #330 and (void) Tcl_GetStringResult(interp) calls in the core.

[Kevin K. <ke...@ac...>]

Jan Nijtmans wrote:
> In 7 places in the core I find calls like:
>      (void) Tcl_GetStringResult(interp)
> but interp->result is not used afterwards. I'm
> refering to tclBasic.c (6) and tclHistory.c (1).
> 
> Shouldn't these calls have been removed as part
> of the TIP #330 implementation? If extensions
> are not allowed any more to access interp->result
> directly, then those calss serve no purpose other than
> slowing down Tcl. It might break extensions which still
> use interp->result, but due to TIP #330, that's exactly
> what users of Tcl 8.6 should expect.

If we had made the Tcl_Interp data structure opaque in
8.5, I'd agree with you wholeheartedly.  We've moved too slowly
on this, and been too quiet about the initial warnings.
Since we didn't vote to take out interp->result altogether,
I'm a little nervous about taking out the code that makes
it useful, particularly since there's not much field
experience left (unless Andreas has reported something
that I've missed) about what this does to currently fielded
extensions. (He maintains the largest extension distribution
that I'm aware of.) Andreas, have you tried building the
AT extension set against 8.6-post-TIP#330?

-- 
73 de ke9tv/2, Kevin