|
From: Joe E. <jen...@fl...> - 2008-11-24 14:54:38
|
Jan Nijtmans wrote: > 2008/11/23 Joe English <jen...@fl...>: > > TIP#340: NO. > > > > I support the goals of this TIP, but not the specific > > proposed refactoring. It leaves Tcl_SetResult() in a > > broken state: with an incorrect const qualifier on the > > second argument and a worthless vestigial third argument. > > > > What is called for is a new, two-argument, const-correct > > entry point: > > > > void Tcl_SetResultString(Tcl_Interp *, const char *); > > Does this mean that adding such a function would > change your vote to a YES? Does your NO mean > that this TIP doesn't go far enough? Yes on both counts. > For the record, I think as well that Tcl_SetResult > should be deprecated, but I didn't want to go > that far in this TIP because it means a lot of work, > changing all the calls in Tcl and Tk. --Joe English jen...@fl... |