Re: [TCLCORE] TIP #340: Const Qualification of Tcl_SetResult's Argument and -Wwrite-strings

[Jan N. <nij...@us...>]

2008/11/17 Jan Nijtmans <nij...@us...>:
> The vast majority of calls use 0 or TCL_VOLATILE, and that's
> the CONST case. So we could reserve Tcl_SetResult for
> the CONST case and force to use Tcl_SetObjResult in
> the other cases. That would already be a lot less work
> than modify all Tcl_SetResult calls in the core.

In a quick scan, I can only find 4 Tcl_SetResult calls in the
core in which the 3th argument is not 0 or TCL_VOLATILE:
   tclDictObj.c (1 line)
   tclTest.c (2 lines)
   tclThreadTest.c (1 line)
Well, dict is only introduced in Tcl 8.5, and the other two
files are only meant for test cases.

I will modify those 3 files to use Tcl_SetObjResult in stead
of Tcl_Result. That is zero risk and it will ease the discussion
about this subject: For calls in the core the second argument
of Tcl_SetResult is supposed to be a const!

Thanks, Andreas, for triggering this idea. Let's think more
about it.

Regards,
        Jan Nijtmans