From: Alexandre F. <ale...@gm...> - 2008-11-11 12:53:06
|
On Mon, Nov 10, 2008 at 6:57 PM, Donal K. Fellows <don...@ma...> wrote: > Alexandre Ferrieux wrote: >> >> I propose to just patch Tk_CanvasGetCoordFromObj so that it calls >> GetDoublePixels instead of the current shenanigans. >> Any objection ? > > It's worth trying and seeing what blows up in the test suite. And then > deciding whether the answer that the test suite was looking for was the > right thing or not. (I suspect that getting rid of the shenanigans will > be a good thing, but let's double-check that...) Ready to do so; however right now HEAD has a bunch (12) of Tk test failures (XP SP2): ==== bind-22.10 HandleEventGenerate FAILED ==== bind-22.10 FAILED ==== frame-2.8 toplevel configuration options FAILED ==== frame-2.8 FAILED ==== text-19.16 DeleteChars procedure, updates affecting topIndex FAILED ==== text-19.16 FAILED ==== text-33.11 peer widget -start, -end FAILED ==== text-33.11 FAILED ==== textDisp-29.2 miscellaneous: lines wrap but are still too long FAILED ==== textDisp-29.2 FAILED ==== textDisp-29.2.1 miscellaneous: lines wrap but are still too long FAILED ==== textDisp-29.2.1 FAILED ==== textDisp-29.2.2 miscellaneous: lines wrap but are still too long FAILED ==== textDisp-29.2.2 FAILED ==== textDisp-29.2.3 miscellaneous: lines wrap but are still too long FAILED ==== textDisp-29.2.3 FAILED ==== textDisp-29.2.4 miscellaneous: lines wrap but are still too long FAILED ==== textDisp-29.2.4 FAILED ==== textDisp-32.2 elide and tags FAILED ==== textDisp-32.2 FAILED ==== textImage-3.2 delayed image management FAILED ==== textImage-3.2 FAILED ==== + winDialog-1.1 hanging (bgerror window saying : while executing "testwinevent $::tk_dialog $button WM_LBUTTONDOWN 1 0x000a000b" (procedure "Click" line 2) Yes, the error string is _empty_). Am I alone to witness all this ? I hesitate to fiddle with the coordinate system with such a background... |