[Tcl-bugs] [ tcl-Bugs-1631922 ] TEA should check actual existence of private headers

[SourceForge.net <no...@so...>]

Bugs item #1631922, was opened at 2007-01-10 02:23
Message generated for change (Settings changed) made by rmax
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1631922&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 70. Sample Extension
Group: None
Status: Open
Resolution: Fixed
>Priority: 9
Private: No
Submitted By: Jeffrey Hobbs (hobbs)
Assigned to: Jeffrey Hobbs (hobbs)
Summary: TEA should check actual existence of private headers

Initial Comment:
TEA_PRIVATE_(TCL|TK)_HEADERS says "checking for", but only uses whatever values are in tclConfig.sh.  It should error (or at least warn) if TCL|TK_SRC_DIR does not exist (as it will probably just lead to an error in make).

----------------------------------------------------------------------

Comment By: Reinhard Max (rmax)
Date: 2008-02-04 16:59

Message:
Logged In: YES 
user_id=124643
Originator: NO

This fix breaks tcl.m4 in systems where the private headers got installed
along with the public ones and ${TCL_SRC_DIR} doesn't exist (anymore),
which is common when Tcl gets installed as part of the OS distribution. 

So, in addition to ${TCL_SRC_DIR} the location found by
TEA_PUBLIC_TCL_HEADERS should be checked for tclInt.h .

----------------------------------------------------------------------

Comment By: Jeffrey Hobbs (hobbs)
Date: 2007-02-09 18:12

Message:
Logged In: YES 
user_id=72656
Originator: YES

fixed

----------------------------------------------------------------------

Comment By: Georgios Petasis (petasis)
Date: 2007-02-09 13:49

Message:
Logged In: YES 
user_id=92283
Originator: NO

The changes made in tcl.m4 to close this bug are not appropriate. In fact,
the smaplextension now fails at least under fedora core 6: The changes
should be:

Instead of:
if test ! -d "${TK_SRC_DIR}/tkInt.h" ; then
   AC_MSG_ERROR([Cannot find private header tkInt.h in ${TK_SRC_DIR}])
fi

Should be:
if test ! -f "${TK_SRC_DIR}/generic/tkInt.h" ; then
   AC_MSG_ERROR([Cannot find private header tkInt.h in ${TK_SRC_DIR}])
fi

Why? 

a) test -d checks for existence of directories. Not for single file. It
will return false, even if the file is there. In my system, only test -f
works when the file is there...

b) We should also put /generic/<file>, as TK_SRC_SIR in tkConfig.h should
point to the root of the sources, and not in the generic directory. If you
set TK_SRC_SIR to include generic (to force configure to not fail), you end
up ith generic/generic/ in includes :-(

Of course, the same must be changed also for tclInt.h...

Can you please fix this?

----------------------------------------------------------------------

Comment By: Jeffrey Hobbs (hobbs)
Date: 2007-02-09 01:10

Message:
Logged In: YES 
user_id=72656
Originator: YES

added to sample 2007-02-08.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1631922&group_id=10894