From: <no...@so...> - 2002-10-04 08:26:46
|
Bugs item #602566, was opened at 2002-08-30 19:46 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=602566&group_id=10894 Category: 69. Other >Group: 8.4.1 >Status: Closed Resolution: Fixed Priority: 2 Submitted By: David N. Welton (davidw) Assigned to: Donal K. Fellows (dkf) Summary: should use 'exists' instead of 'exist' Initial Comment: This is a very low priority nitpick, but I noticed that info exist is used in place of info exists in several places. 'exists' is what's documented, and Tcl should use that, for consistency's sake. cd ~/download/tcl/ find . -type f -print0 | xargs -0 -e grep -n -e 'info exist ' ./library/http/http.tcl:174: if {[info exist state(-command)]} { ./library/http/http.tcl:559: if {[info exist state]} { ./library/init.tcl:43: if {[info exist env(TCLLIBPATH)]} { ./library/init.tcl:63: if {[info exist ::tcl_pkgPath]} { ./library/outoftheway_init.tcl:42: if {[info exist env(TCLLIBPATH)]} { ./library/outoftheway_init.tcl:60:if {[info exist tcl_pkgPath]} { ./tests/autoMkindex.test:107:if {[info exist auto_mkindex_parser::initCommands]} { ./tests/autoMkindex.test:112: if {[info exist saveCommands]} { ./tests/autoMkindex.test:114: } elseif {[info exist auto_mkindex_parser::initCommands]} { ./tests/autoMkindex.test:347:if {[info exist saveCommands]} { ./tests/binary.test:609: list [binary scan abc a5 arg1] [info exist arg1] ./tests/binary.test:648: list [binary scan abc A5 arg1] [info exist arg1] ./tests/env.test:201: set result [info exist env(THIS_SHOULDNT_EXIST)] ./tests/env.test:218: # The info exist command should be in synch with the env array. ./tests/http.test:23: if {[info exist http2]} { ./tests/http.test:496:if {[info exist removeHttpd]} { ./tests/httpd:78: if {![info exist data(length_orig)]} { ./tests/httpd:106: if {![info exist data(mime,content-length)]} { ./tests/httpold.test:22: if {[info exist httpold]} { ./tools/man2help2.tcl:871: if {[info exist bitmap]} { This should be easy to fix with a script. ---------------------------------------------------------------------- >Comment By: Donal K. Fellows (dkf) Date: 2002-10-04 09:26 Message: Logged In: YES user_id=79902 Picky picky picky. (Fixed; thanks for bringing this to our attention.) ---------------------------------------------------------------------- Comment By: David N. Welton (davidw) Date: 2002-10-03 19:25 Message: Logged In: YES user_id=240 Here's a patch ---------------------------------------------------------------------- Comment By: David N. Welton (davidw) Date: 2002-10-03 19:21 Message: Logged In: YES user_id=240 You forgot 'file exist[^s]'. Thankyou. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=602566&group_id=10894 |