[MACTCL] Re: tcl8.4.10 threads enabled compile issue

[Zoran V. <zv...@ar...>]

Am 08.06.2005 um 19:54 schrieb Jeff Hobbs:
>
> Hey Jeff
> Just downloaded tcl8.4.10 from SF
> Looks like someone has checked in code that hasn't been tested with  
> threads
> ./configure --enable-threads --prefix=~/compiled/
> tclUnixNotfy.c: In function `Tcl_FinalizeNotifier':
> tclUnixNotfy.c:297: too few arguments to function `Tcl_JoinThread'
> make: *** [tclUnixNotfy.o] Error 1


The deal was join the notifier thread when finalizing the notifier
subsystem instead of (potentially) exiting the process while the
thread still lives (this is a subtle race condition).
Here is more details about that:

   2005-05-31  Zoran Vasiljevic <vas...@us...>

         * unix/tclUnixNotfy.c: the notifier thread is now created as
         joinable thread and it is properly joined in  
Tcl_FinalizeNotifier.
         This is an attempt to fix the Tcl Bug #1082283.

But... I see where is the problem!

The problem is with the gcc 4.0.0 delivered with Mac OS 10.4 Tiger.
When you compile with it, the compilation goes OK!
When you go back to 10.3 and compile with 3.x then it spots the
problem and barks. Linux GCC's I have access to are all on 3.x
version and they also catch the error.

Uh... I'm terribly sorry for this one! This means we have 8.4.10
broken... This is entirely my fauilt. I should have compiled the
core on other platforms as well. But I never thought that an
error of that kind would really be possible, at least not in the
GCC. Some things you simply must trust!

I truely apologize for all problems this created and I really
do not know what should I say more :-(

Zoran