#388 eliminate double substitution from configure.in

closed-fixed
5
2010-08-13
2005-01-30
Joe English
No

MSW reports (on the chat) that latest changes to
configure.in / tcl.m4 (#1081595) break the build on NetBSD.

Problem: "configure produces makefile targets like
libtcl`echo ... | tr -d ...`".

Discussion

  • Joe English

    Joe English - 2005-01-30

    Logged In: YES
    user_id=68433

    Probable cause of the problem: the line

    | eval "TCL_LIB_FILE=${TCL_LIB_FILE}"

    (configure.in r1.125 line 448), which was removed in r1.126,
    is actually used for more than just expanding ${TCL_DBGX}.
    In particular, if TCL_LIB_VERSIONS_OK is set to "nodots", it
    contains other shell escapes.

    Attached patch attempts to fix the problem by restoring this
    line.

     
  • Joe English

    Joe English - 2005-01-30

    Logged In: YES
    user_id=68433

    Followup: Double-eval is also required for TCL_STUB_LIB_FILE.

    We should really consider handling this TCL_TRIM_DOTS /
    TCL_LIB_VERSIONS_OK / TCL_{UN}SHARED_LIB_SUFFIX mess
    differently.

     
  • Joe English

    Joe English - 2005-01-30

    Patch to unix/configure.in r1.126 take 2

     
  • Joe English

    Joe English - 2005-01-30

    Logged In: YES
    user_id=68433

    Patch confirmed. Also checked tk/unix/configure.in for
    similar issues; no double-evals were removed in the DBGX
    purge, Tk CVS HEAD compiles OK on NetBSD.

    What's not clear is whether NetBSD even needs to use
    ${TCL_TRIM_DOTS} anymore, but that's an issue for another time.

     
  • Joe English

    Joe English - 2005-01-30
    • status: open --> closed-fixed
     
  • Joe English

    Joe English - 2005-01-30
    • status: closed-fixed --> open-fixed
     
  • Joe English

    Joe English - 2005-01-30
    • assigned_to: jenglish --> hobbs
     
  • Joe English

    Joe English - 2005-01-30

    Logged In: YES
    user_id=68433

    Reopening -- I have autoconf 2.59, not 2.57, so can't
    regenerate the configure script. Jeff, could you take care
    of this? Thanks.

    (BTW, why are we using 2.57?)

     
  • Don Porter

    Don Porter - 2005-01-31
    • summary: Missing eval in configure.in --> eliminate double substitution from configure.in
    • labels: 104252 --> 85. tclconfig
     
  • Don Porter

    Don Porter - 2005-01-31

    Logged In: YES
    user_id=80530

    Committed the generated
    unix/configure file.

    Moving this report over to
    a Feature Request. Let us please
    find a way to solve these problems
    without using an "eval".

    Getting rid of the double
    substitution was going to be
    an important step toward fixing
    Bug 553544.

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2005-05-31

    Logged In: YES
    user_id=72656

    Is there anything here to fix?

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2005-05-31
    • status: open-fixed --> pending-fixed
     
  • Joe English

    Joe English - 2005-05-31
    • status: pending-fixed --> closed-fixed
     
  • Joe English

    Joe English - 2005-05-31

    Logged In: YES
    user_id=68433

    > Is there anything here to fix?

    Not that I'm aware of. It would be _nice_ to get rid of all
    the double-evals in configure.in, but not _necessary_ afaict.

     
  • Don Porter

    Don Porter - 2005-06-01
    • status: closed-fixed --> open-fixed
     
  • Don Porter

    Don Porter - 2005-06-01

    Logged In: YES
    user_id=80530

    the remaining request here
    (re-opening) is to get rid of
    any remaining "eval"s in
    configure.in / tcl.m4 .

    Most of the eval's were there
    originally to substitute $(TCL_DBGX),
    but that's gone now. so they
    ought to be able to go too.

    The presence of eval's makes
    it more difficult to solve the
    problem of handling spaces in
    pathnames (554348).

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2010-08-13
    • status: open-fixed --> closed-fixed