#715 Array bounds read errors in Tcl_Free/Tcl_Alloc

obsolete: 8.0p2
closed-fixed
nobody
2
2001-04-16
2000-10-26
Anonymous
No

OriginalBugID: 1372 Bug
Version: 8.0p2
SubmitDate: '1999-03-02'
LastModified: '1999-10-30'
Severity: LOW
Status: Released
Submitter: pat
ChangedBy: hobbs
OS: Windows NT
OSVersion: 4.0
Machine: X86
FixedDate: '1999-10-30'
FixedInVersion: 8.3b1
ClosedDate: '2000-10-25'

Name:
Christopher M. Love

ReproducibleScript:
I have compiled Tcl/Tk with -DUSE_TCLALLOC=0, and Tcl and Tk still use
these functions anyway in tclIOUtil.c and tkGrid.c. While running my
application which uses the Grid layout, Purify 6.0 for NT showed there
was a place in Tcl_Free where memory was being read beyond an area of
allocated memory. While I didn't experience an exception, there are times
when a this type of activity does cause an exception. Here's what I'm
requesting:
1. Can you fix the ABR errors?
2. I replaced the calls in these files to Tcl_Free() and Tcl_Alloc()
with ckalloc() and ckfree(). When compiled with USE_TCLALLOC=0,
the errors disappear. Shouldn't the source you distribute do
this as well. If not, is there some reason for using Tcl_Free()
and Tcl_Alloc() that I'm not aware of?

ObservedBehavior:
I found ABR (Array Bounds Reads where the program reads past allocated memory)
in Purify for NT. The source was compiled with Visual C++ 6.0 on NT 4.0

DesiredBehavior:
I would expect Purify not to show these errors as they can cause exceptions.
I would also expect that all Tcl/Tk source files adhear to using ckfree() and
ckalloc(), and not call Tcl_Free and Tcl_Alloc directly.

Fixed as per suggestions.
-- 10/30/1999 hobbs

Discussion

  • Brent B. Welch

    Brent B. Welch - 2000-10-26
    • priority: 5 --> 2
    • status: open --> closed-fixed
     
  • Don Porter

    Don Porter - 2001-04-16
    • labels: 104246 --> 41. Memory Allocation