#617 bug in "info complete" command called with binary strings

obsolete: 8.0p2
closed-fixed
nobody
2
2001-04-16
2000-10-26
Anonymous
No

OriginalBugID: 689 Bug
Version: 8.0p2
SubmitDate: '1998-10-02'
LastModified: '1999-08-06'
Severity: MED
Status: Released
Submitter: hershey
ChangedBy: hobbs
OS: All
OSVersion: NA
Machine: NA
FixedDate: '1999-08-06'
FixedInVersion: 8.1
ClosedDate: '2000-10-25'

Hi,

info complete [list 1 2 [format binary H 00]]

used to return 0, because the completer was using the string based routines.

This is a simple patch to fix the behavior:

--- tcl8.0.3/generic/tclCmdIL.c Sat Aug 8 04:41:58 1998

+++ tcl8.0.3.mine/generic/tclCmdIL.c Thu Sep 10 09:32:17 1998

@@ -762,19 +762,17 @@

int objc; /* Number of arguments. */

Tcl_Obj *CONST objv[]; /* Argument objects. */

{

- char *command;

-

if (objc != 3) {

Tcl_WrongNumArgs(interp, 2, objv, "command");

return TCL_ERROR;

}

- command = Tcl_GetStringFromObj(objv[2], (int *) NULL);

- if (Tcl_CommandComplete(command)) {

+ if (TclObjCommandComplete(objv[2])) {

Tcl_SetIntObj(Tcl_GetObjResult(interp), 1);

} else {

Tcl_SetIntObj(Tcl_GetObjResult(interp), 0);

}

+

return TCL_OK;

}

This was fixed in 8.1 with the intro of Unicode and full
binary support through all of Tcl and Tk. Tcl was not
fully binary-safe in 8.0.
-- 08/06/1999 hobbs

Discussion

  • Brent B. Welch

    Brent B. Welch - 2000-10-26
    • priority: 5 --> 2
    • status: open --> closed-fixed
     
  • Don Porter

    Don Porter - 2001-04-16
    • labels: 104246 --> 17. Commands I-L
    • summary: bug in "info complete" command called with binary strings --> bug in "info complete" command called with binary strings
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks