Tcl / Read-Only Bugs / #5240 If a temporary file cannot be opened Tcl

The Tool Command Language implementation

#5240 If a temporary file cannot be opened Tcl_LoadFile can crash

Status: pending-fixed

Owner: Don Porter

Labels: 37. File System (341)

Priority: 5

Updated: 2014-09-04

Created: 2013-05-18

Creator: Roy Keene

Private: No

copyToPtr can be NULL and it should be checked before passing it to Tcl_IncrRefCount()

http://core.tcl.tk/tcl/artifact/26a06b015bfec491bb32903223af5152b3ceeb0d?ln=3230-3231

Prelimnary patch attached, however after applying this patch I then get:
Tcl_FSGetFileSystemForPath called with NULL object
Segmentation fault (core dumped)

Discussion

Roy Keene - 2013-05-18

summary: If a temporary file cannot be opened ... can segfault --> If a temporary file cannot be opened Tcl_LoadFile can crash
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Roy Keene - 2013-05-18

Preliminary patch

tcl-8.6.0-bug3613569-1segfaultonnotmp.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Don Porter - 2013-05-20

Committed to trunk a forward porting of the
logic in the 8.5 branch on how to react when
NULL is returned. Please comment if the solution
is not satisfactory.

Looks like the bug came in with TIP 357 implementation.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Don Porter - 2013-05-20

status: open --> pending-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

If a temporary file cannot be opened Tcl_LoadFile can crash

The Tool Command Language implementation

Group

Searches

Help

#5240 If a temporary file cannot be opened Tcl_LoadFile can crash

Discussion