#5074 Visual studio compiler check fails

obsolete: 8.6b3
pending-fixed
9
2012-07-17
2012-07-17
No

When using the makefile.vc in the win directory to build Tcl or the thread and itcl packages, there is a check to see if the build is configured to build with Microsoft Visual Studio/C. This check is not complete (e.g fails when using Visual Studio Express 10 and SDK 7.1 to build 64 bit). The attached patches remove the check. When you're using the makeifle.vc to build Tcl/Itcl/Thread, you'll need nmake, which is only available when the VC build environment is configured.

Jos.

Discussion

  • Decoster Jos

    Decoster Jos - 2012-07-17

    Remove compiler check from Tcl makefile.vc

     
  • Decoster Jos

    Decoster Jos - 2012-07-17

    Remove compiler check from Thread makefile.vc

     
  • Donal K. Fellows

    • milestone: --> obsolete: 8.6b3
    • priority: 5 --> 9
    • assigned_to: stwo --> nobody
     
  • Jan Nijtmans

    Jan Nijtmans - 2012-07-17
    • assigned_to: nobody --> patthoyts
     
  • Jan Nijtmans

    Jan Nijtmans - 2012-07-17

    I have doubts about this one: If the 64-bit compiler has
    different macro's, shouldn't that be tested for, in
    stead of simply removing the check?

    Pat, you seem to be the expert in this.

     
  • Decoster Jos

    Decoster Jos - 2012-07-17

    Hi Jan,

    While I agree on that, I could not see what would be a good candidate to add in the VC-express + SDK setup. These are available:

    INCLUDE (has a list of VC include paths)
    LIBS or LIBPATH (list of VC lib paths)
    WindowsSDKDir

     
  • Jan Nijtmans

    Jan Nijtmans - 2012-07-17

    So, how about adding
    && !defined(WindowsSDKDir)
    to the end of the existing check.
    Does that work, or are additional
    changes needed?

     
  • Decoster Jos

    Decoster Jos - 2012-07-17

    That should do it. Same change needed in itcl and thread.

     
  • Decoster Jos

    Decoster Jos - 2012-07-17

    I'll prepare a patch after testing.

     
  • Decoster Jos

    Decoster Jos - 2012-07-17

    This should be added to the test in the different makefile.vc files:

    && !defined(WINDOWSSDKDIR)

    (note the upper case). Want me to make a patch for this change or if the line above sufficient?

     
  • Jan Nijtmans

    Jan Nijtmans - 2012-07-17

    Fixed in Tcl and Tk (all open branches), thread, tdbc and itcl.

    Jos, please veryfy whatever you can (I don't have
    a 64-bit build environment)

     
  • Jan Nijtmans

    Jan Nijtmans - 2012-07-17
    • status: open --> pending-fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks