#5069 Thread extension not building with makefile. when in release

obsolete: 8.6b3
closed-fixed
9
2012-07-18
2012-07-12
No

The Threads package has a makefile.vc to build with Visual Studio in directory win/vc. When adding the Thread package to the pkgs directory for a 'batteries included' Tcl release, the makefile.vc file is moved from directory win/vc to directory win. This invalidates the ROOT variable used in the makefile.vc. It still has value ..\.. where after copying it should become ..

Discussion

  • Don Porter

    Don Porter - 2012-07-12

    This was corrected before in checkin 6593e21b9c.

    It got broken again in checkin 51cf545767.

    There's a natural tug-o-war going on between making
    builds work in a fossil checkout and making them work
    in the released distribution. Unless there's some value
    in having those two keep different directory layouts, I
    recommend getting rid of the vc subdir from the very beginning.

    Otherwise we'll just keep fixing this again and again.

     
  • Zoran Vasiljevic

    Don, I have, as already stated, no experience with Windows build.
    I must say I did not understand your answer :-(
    Do I need to do anything? I normally fresh-clone the distro, make
    changes, commit and push.

     
  • Decoster Jos

    Decoster Jos - 2012-07-16

    To build Thread in a 'Betteries' included' Tcl, under the pkgs directories, one of the following needs to be done:

    - put all files of tcl/pkgs/thread/win/vc in thread/win and adapt the ROOT in the thread makefile.vc

    or

    - modify tcl/win/makefile.vc to also look in pkgs/???/win/vc directories

    I prefer to remove the thread/win/vc directory.

     
  • Don Porter

    Don Porter - 2012-07-16
    • priority: 5 --> 9
     
  • Decoster Jos

    Decoster Jos - 2012-07-16
     
  • Decoster Jos

    Decoster Jos - 2012-07-16

    The attached file 'vc.diff' is the 'fossil diff' output after moving the files from the win.vc to the win directory and updating the README file.

     
  • Jan Nijtmans

    Jan Nijtmans - 2012-07-16
    • assigned_to: vasiljevic --> nijtmans
    • status: open --> pending-fixed
     
  • Jan Nijtmans

    Jan Nijtmans - 2012-07-16

    Done as suggested by Jos. OK?

    Thanks, Jos!

     
  • Decoster Jos

    Decoster Jos - 2012-07-17

    Patch for Makefile.in to update new file location in 'make dist'

     
  • Decoster Jos

    Decoster Jos - 2012-07-17

    I attached a patch to 'Makefile.in' which updates the changed windows patch in 'make dist'

     
  • Decoster Jos

    Decoster Jos - 2012-07-17
    • status: pending-fixed --> open-fixed
     
  • Jan Nijtmans

    Jan Nijtmans - 2012-07-17
    • status: open-fixed --> pending-fixed
     
  • Jan Nijtmans

    Jan Nijtmans - 2012-07-17

    Fixed in trunk. OK now?

     
  • Decoster Jos

    Decoster Jos - 2012-07-18

    OK now for Tcl and for Itcl, Thread and Tdbc in the pkgs dir. Thanks.

     
  • Decoster Jos

    Decoster Jos - 2012-07-18
    • status: pending-fixed --> open-fixed
     
  • Jan Nijtmans

    Jan Nijtmans - 2012-07-18
    • status: open-fixed --> closed-fixed
     
  • Jan Nijtmans

    Jan Nijtmans - 2012-07-18

    Thanks for testing! Closing

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks