#3901 [eof] check is before [gets], not after it

obsolete: 8.5.0
closed-fixed
9
2008-02-26
2008-01-10
No

Hi,

The http package is not compatible with IOCPSOCK (a replacement socket channel driver for WinNT systems) only because the check for EOF in [http::Event] is placed before the [gets] operation.

Moving it to after read/gets operation will still work with channel drivers based on select()'s polling semantics, too, and save a needless event loop iteration as well.

Discussion

  • Donal K. Fellows

    • priority: 5 --> 9
     
  • Pat Thoyts

    Pat Thoyts - 2008-02-26
    • status: open --> closed-fixed
     
  • Pat Thoyts

    Pat Thoyts - 2008-02-26

    Logged In: YES
    user_id=202636
    Originator: NO

    Applied the suggested change and incremented the http package version to 2.5.5 so it can be tested for. Checking this change doesn't reveal any problems with the tkchat plugins which use http -handler, -timeout and -command so it seems safe enough.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks