#3141 Tcl 8.4 release compile error

obsolete: 8.4.9
closed-fixed
7
2005-05-30
2005-05-18
No

When compiling in release mode using the threaded
memory allocator, the following code causes a problem:

in tclWinThrd.c, function TclpFinalizeThreadData, near
line #705:

#if defined(USE_THREAD_ALLOC) && !defined(TCL_MEM_DEBUG)
if (indexPtr == &key) {
TclpFreeAllocCache(result);
return;
}
#endif

There is no variable named "key". I'm not sure what
the precise intent here is.

..\win\tclWinThrd.c(688) : error C2065: 'key' :
undeclared identifier
..\win\tclWinThrd.c(1046) : warning C4142: benign
redefinition of type

Discussion

  • Joe Mistachkin

    Joe Mistachkin - 2005-05-18

    Logged In: YES
    user_id=113501

    Perhaps the author wanted to do this?

    #if defined(USE_THREAD_ALLOC) && !defined(TCL_MEM_DEBUG)
    if (indexPtr == &dataKey) {
    TclpFreeAllocCache(result);
    return;
    }
    #endif

     
  • Joe Mistachkin

    Joe Mistachkin - 2005-05-18

    Logged In: YES
    user_id=113501

    Issue introduced:

    version 1.24.2.10, Thu Apr 7 11:29:33 2005 UTC

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2005-05-30

    Logged In: YES
    user_id=72656

    Fixed in head - the decl was lower in the file. Renamed to
    tlsKey to be more descriptive. Go ahead and test (passes
    test suite).

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2005-05-30
    • assigned_to: andreas_kupries --> vasiljevic
    • status: open --> pending-fixed
     
  • Joe Mistachkin

    Joe Mistachkin - 2005-05-30
    • status: pending-fixed --> open-fixed
     
  • Joe Mistachkin

    Joe Mistachkin - 2005-05-30

    Logged In: YES
    user_id=113501

    Fix confirmed in HEAD. However, this same error still
    exists in core-8-4-branch.

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2005-05-30

    Logged In: YES
    user_id=72656

    I expect you mean the opposite, since I only fixed
    core-8-4-branch ...

     
  • Joe Mistachkin

    Joe Mistachkin - 2005-05-30

    Logged In: YES
    user_id=113501

    Your previous message said you fixed it in HEAD?

    I'm really confused now, I see the declaration way above the
    usage in HEAD. Therefore, it must be fixed in HEAD;
    however, it is not named "tlsKey".

    In core-8-4-branch, the declaration for 1.24.2.9 2004/10/28
    21:12:38 is on line 1068, far beyond the usage.

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2005-05-30
    • status: open-fixed --> closed-fixed
     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2005-05-30

    Logged In: YES
    user_id=72656

    You must be accessing anoncvs, which is delayed.

     
  • Zoran Vasiljevic

    Logged In: YES
    user_id=95086

    I have fixed the HEAD (8.5) now; please try it.
    Jeff has fixed the core-8-4-branch.
    Sorry for this, but I do not have Win platform
    to test, therefore this one creeped in.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks