#2296 Tcl_FSPathInFilesystemProc return value man page mismatch

obsolete: 8.4.2
closed-fixed
None
5
2003-06-23
2003-04-13
No

The manpage for Tcl_FSPathInFilesystemProc says to
return
TCL_ERROR for path not belonging to vfs. When in fact
the code expects -1. See below.

**************************************************************
MANPAGE - PATHINFILESYSTEMPROC
The pathInFilesystemProc field contains the
address of a function
which is called to determine whether a given
path object belongs to
this filesystem or not. Tcl will only
call the rest of the
filesystem functions with a path for which
this function has
returned TCL_OK. If the path does not belong,
TCL_ERROR should be
returned.

*************************************************************
CODE - TclIOUtil.c (4875)
/*
* Call each of the "pathInFilesystem" functions in
succession. A
* non-return value of -1 indicates the particular
function has
* succeeded.
*/

while ((retVal == NULL) && (fsRecPtr != NULL)) {
Tcl_FSPathInFilesystemProc *proc =
fsRecPtr->fsPtr->pathInFilesystemProc;
if (proc != NULL) {
ClientData clientData = NULL;
int ret = (*proc)(pathObjPtr, &clientData);
if (ret != -1) {

Discussion

  • Peter MacDonald

    Peter MacDonald - 2003-04-13

    Logged In: YES
    user_id=190660

    I think there are also some old modeString that should be
    mode
    references in man page as well.

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2003-05-11
    • assigned_to: nobody --> vincentdarley
     
  • Vince Darley

    Vince Darley - 2003-06-23

    Logged In: YES
    user_id=32170

    Fixed. The modeString bit is ok, I think.

     
  • Vince Darley

    Vince Darley - 2003-06-23
    • status: open --> closed-fixed