#1696 memory.n wrong (out of date?)

obsolete: 8.4a4
closed-fixed
5
2001-12-28
2001-11-30
Don Porter
No

The commands documented in doc/memory.n are:

memory info
memory trace on|off
memory validate on|off
memory trace_on_at_malloc $count
memory break_on_malloc $count
memory display file

The commands actually implemented in
generic/tclCkalloc.c are:

checkmem
memory active $file
memory break_on_malloc $count
memory info
memory init on|off
memory tag $string
memory trace on|off
memory trace_on_at_malloc $count
memory validate on|off

They ought to match.

The attached patch bring the MemoryCmd() comment
within generic/tclCkalloc.c up to date, and updating
doc/memory.n is left to the maintainer.

Discussion

  • Don Porter

    Don Porter - 2001-12-18

    Logged In: YES
    user_id=80530

    Here's an updated patch:

    * generic/tclCkalloc.c (MemoryCmd,
    TclFinalizeMemorySubsystem):
    Added the [memory onexit] command, intended to
    replace [checkmem].

    * doc/DumpActiveMemory.3:
    * doc/memory.n: Updated documentation for [memory]
    and related
    matters. [Bug 487677]

    * mac/tclMacBOAMain.c (Tcl_Main, CheckmemCmd):
    Removed all the
    machinery for the [checkmem] command that is
    completely duplicated
    by code in generic/tclCkalloc.c.

    * generic/tclBinary.c:
    * generic/tclListObj.c:
    * generic/tclObj.c:
    * generic/tclStringObj.c: Removed references to
    [checkmem] in
    comments, referencing [memory active] instead, since
    it is
    documented.

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2001-12-28
    • assigned_to: hobbs --> dgp
     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2001-12-28

    Logged In: YES
    user_id=72656

    looks good to me.

     
  • Don Porter

    Don Porter - 2001-12-28

    Logged In: YES
    user_id=80530

    committed to HEAD (8.4a4) after a few improvements.
    Final version of patch attached.

     
  • Don Porter

    Don Porter - 2001-12-28
     
  • Don Porter

    Don Porter - 2001-12-28
    • status: open --> closed-fixed