#1369 Unix newlines in Windows batch files

obsolete: 8.4a1
closed-fixed
5
2001-11-20
2000-10-26
Anonymous
No

OriginalBugID: 6347 Bug
Version: 8.4a1
SubmitDate: '2000-10-09'
LastModified: '2000-10-25'
Severity: MED
Status: UnAssn
Submitter: techsupp
OS: Windows 98
FixedDate: '2000-10-25'
ClosedDate: '2000-10-25'

Name:
David Cuthbert

Comments:
Opening rmd.bat and mkd.bat in a text editor and resaving them usually
works.

ObservedBehavior:
Cannot build from the tcl8.4a1 ZIP file (using Win98, MSVC 5 and makefile.vc). The Makefile fails to create the Release and Debug directories because the mkd.bat and rmd.bat scripts were saved with Unix linefeeds. (Symptom: Make echos the word "OFF" twice, tries to compile the first file, and fails)

Discussion

  • Donal K. Fellows

    • labels: 104246 --> 104681
     
  • Donal K. Fellows

    • labels: 104681 --> 53. Configuration and Build Tools
     
  • David Gravereaux

    Logged In: YES
    user_id=7549

    I beleive the source releases are made from the unix
    makefile, and thus the cvs checkout was done with a unix
    cvs client which sets \n as <eol>. IMO, this is a TEA
    misunderstanding which states all source files should in LF
    mode. Some just can't be in LF. Same is true for the .ini
    file used for the help compiler (CRLF or death).

     
  • Andreas Kupries

    Andreas Kupries - 2001-08-23
    • assigned_to: nobody --> mdejong
     
  • Mo DeJong

    Mo DeJong - 2001-09-08

    Logged In: YES
    user_id=90858

    Well, perhaps we could check the files into CVS
    using the -k flag. That would treat the file
    as binary so that \r\n would be used as EOL
    even when checked out on a UNIX system.

     
  • David Gravereaux

    Logged In: YES
    user_id=7549

    I find that treating CVS's behavior of <EOL> is perfect for
    {editing mode}, but building and running should require
    some added work in the makefiles to ensure proper <EOL> on
    the special files. See 219217.

    One cannot guarentee what <EOL> will be upon checkout. Fix
    it in the makefiles.

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2001-09-08

    Logged In: YES
    user_id=72656

    Go ahead with the -k flag.

     
  • Mo DeJong

    Mo DeJong - 2001-09-08
    • status: open --> closed-fixed
     
  • Mo DeJong

    Mo DeJong - 2001-09-08

    Logged In: YES
    user_id=90858

    I changed the files to binary with CRLF linefeeds.
    That should fix things, if not this bug report
    can be re-opened.

     
  • David Gravereaux

    • status: closed-fixed --> open-fixed
     
  • David Gravereaux

    Logged In: YES
    user_id=7549

    Use of the -kb on a text file is improper, your just going
    to twist yourself in a knot.

    Say I do a checkout on Mac and edit the file and my editor
    decided to strip off the LF. Then I commited.

    haha.

    you'll be revisiting this one day!

     
  • Mo DeJong

    Mo DeJong - 2001-09-09
    • assigned_to: mdejong --> davygrvy
     
  • Donal K. Fellows

    Newline Fix Script

     
    Attachments
  • Donal K. Fellows

    Logged In: YES
    user_id=79902

    Would the attached script help resolve this more sensibly?

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2001-10-12

    Logged In: YES
    user_id=72656

    This was marked 'Fixed' but 'Open', but I believe it was
    meant to be closed. In any case, perhaps the right
    solution is to run tools/fixEOL.tcl on the necessary files
    before we make the distro.

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2001-10-12
    • status: open-fixed --> closed-fixed
     
  • Mo DeJong

    Mo DeJong - 2001-10-12

    Logged In: YES
    user_id=90858

    I don't think this problem is fixed. I fixed it by adding
    the -kb flag to the files but davygrvy undid my fix and
    left it in the old state. This bug is now assigned to him
    so he should deal with it.

     
  • David Gravereaux

    Logged In: YES
    user_id=7549

    Mo, this is a build/makedist issue, not a repository
    issue. -kb will twist the problem into knots.

    Patch attached for unix/Makefile.in . I know the script
    works, but am unable to test it, as I don't run unix here.

     
  • David Gravereaux

    makedist target change for unix/Makefile.in and script for fixing the needed files.

     
    Attachments
  • David Gravereaux

    • status: closed-fixed --> open-fixed
     
  • David Gravereaux

    Logged In: YES
    user_id=7549

    Should this move over to the patches tracker?

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2001-11-20
    • status: open-fixed --> closed-fixed
     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2001-11-20

    Logged In: YES
    user_id=72656

    fixed in 8.4a4cvs.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks