#1060 Tcl_DbCkfree needs a return value

obsolete: 8.2.1
closed-fixed
Jan Nijtmans
2
2009-07-24
2000-10-26
Anonymous
No

OriginalBugID: 3400 Bug
Version: 8.2.1
SubmitDate: '1999-11-05'
LastModified: '1999-11-11'
Severity: MED
Status: Released
Submitter: techsupp
ChangedBy: hobbs
OS: Windows NT
OSVersion: 4.0
FixedDate: '1999-11-11'
FixedInVersion: 8.2.3
ClosedDate: '2000-10-25'

Name:
Kory Hopkins

ReproducibleScript:
In generic/tclckalloc.c the method Tcl_DbCkfree() needs a return value
at the following state:

if (ptr == NULL) {
return 0;
}

I assume the return value should be 0.

ObservedBehavior:
Could cause some unexpected problems.

fixed
-- 11/11/1999 hobbs

Discussion

  • Brent B. Welch
    Brent B. Welch
    2000-10-26

    • priority: 5 --> 2
    • status: open --> closed-fixed
     
  • Don Porter
    Don Porter
    2001-04-18

    • labels: 104246 --> 41. Memory Allocation
     
  • Jan Nijtmans
    Jan Nijtmans
    2009-02-25

    • assigned_to: nobody --> nijtmans
    • status: closed-fixed --> open-accepted
     
  • Jan Nijtmans
    Jan Nijtmans
    2009-02-25

    I don't think this fix is correct: Tcl_DbCkfree() is used as a macro
    implementation for ckfree which doesn't have a return value, so
    the signature of Tcl_DbCkfree is simply incorrect. It should
    not have a return value at all.

     
  • Could be a pre-C89-ism (i.e. doesn't assume that we've got 'void'). Note that Tcl now does assume C89, and has done for nearly a decade.

     
  • Jan Nijtmans
    Jan Nijtmans
    2009-07-24

    already fixed long ago

     
  • Jan Nijtmans
    Jan Nijtmans
    2009-07-24

    • status: open-accepted --> closed-fixed