Re: [tboot-devel] [PATCH] Suppress GCC 14 allocation size warning in lcptools-v2/pconf_legacy.c

[Christopher B. <sal...@gm...>]

On 1/29/24 02:31, Florian Weimer wrote:
> As far as I can tell, this warning is both technically correct and
> harmless.  The called generate_composite_hash hash function only writes
> SHA1_DIGEST_SIZE bytes and uses byte accesses.
> 
> Thanks,
> Florian
> 
> diff --git a/lcptools-v2/pconf_legacy.c b/lcptools-v2/pconf_legacy.c
> index 443b5cd5525b9fe1..5ebc6c451f7008b1 100644
> --- a/lcptools-v2/pconf_legacy.c
> +++ b/lcptools-v2/pconf_legacy.c
> @@ -324,7 +324,7 @@ static lcp_policy_element_t *create(void)
>               ERROR("Error: no pcrs were selected.\n");
>               return NULL;
>           }
> -        digest = malloc(SHA1_DIGEST_SIZE);
> +        digest = malloc(sizeof(*digest));
>           if (digest == NULL) {
>               ERROR("Error: failed to allocate memory for digest buffer.\n");
>               return NULL;
> 
> 
> 
> _______________________________________________
> tboot-devel mailing list
> tbo...@li...
> https://lists.sourceforge.net/lists/listinfo/tboot-devel

That's not the only patch that file needed. When I submitted the 
original patch to use the correct algorithm, I missed a line.