Re: [tboot-devel] [PATCH] 20_linux_tboot: efi logic was inverted

[Tony C. <tc...@re...>]

> Date: Fri, 10 Jun 2022 02:13:16 +0000
> From: Derek Dolney <z2...@po...>
> To: tbo...@li...
> Subject: Re: [tboot-devel] [PATCH] 20_linux_tboot: efi logic was
> 	inverted
> Message-ID: <18a...@po...>
> Content-Type: text/plain; charset=windows-1252
> 
> On a Thinkpad T430 this would break my boot. I have /sys/firmware/efi
> and I need the noefi kernel param, otherwise it just reboots itself
> about 10-20 sec after SENTER

If your system is booting in efi mode, then it needs efi.
If it's booting in legacy bios mode, then it doesn't need efi

That's how the logic in this grub script is supposed to work.
The current logic is inverted and needs to be corrected so it
works that way.

Have you tried grub2-mkconfig with this corrected grub script?
You can also try editing the module2 stanza in the grub menu with
and without 'noefi' at the end of it.

If your system is booting legacy mode and needs efi to launch
tboot, or if it's booting efi and needs 'noefi' stanza, then
something else is broken.

> On 6/9/22 3:04 PM, Tony Camuso wrote:
>> # HG changeset patch
>> # User Tony Camuso <tc...@re...>
>> # Date 1654800659 14400
>> #????? Thu Jun 09 14:50:59 2022 -0400
>> # Node ID be868f53407d4460491a0e77e5165025153b0329
>> # Parent? 206a47f3e9d2c18c8a3db082216ee6fc3c5d475c
>> 20_linux_tboot: efi logic was inverted
>>
>> There was a RAID0 system that could boot normally, but not through
>> a tboot launch. The problem was that the logic in this script
>> incorrectly appended 'noefi' to the grub.cfg module2 kernel stanza.
>>
>> When 'noefi' was removed from that stanza, the system could boot
>> through a tboot launch. This patch corrects the logic in the script.
>>
>> diff -r 206a47f3e9d2 -r be868f53407d tboot/20_linux_tboot
>> --- a/tboot/20_linux_tboot??? Thu Mar 17 23:58:50 2022 +0200
>> +++ b/tboot/20_linux_tboot??? Thu Jun 09 14:50:59 2022 -0400
>> @@ -105,11 +105,11 @@
>> ?? if [ -d /sys/firmware/efi ] ; then
>> ?????? mb_directive="multiboot2"
>> ?????? mb_mod_directive="module2"
>> -????? mb_extra_kernel="noefi"
>> +????? mb_extra_kernel=""
>> ?? else
>> ?????? mb_directive="multiboot2"
>> ?????? mb_mod_directive="module2"
>> -????? mb_extra_kernel=""
>> +????? mb_extra_kernel="noefi"
>> ?? fi
>> ?
>> ?? printf "menuentry '${title}' ${CLASS} {\n" "${os}" "${tboot_version}"
>> "${version}"
>>
>>
>>
>> _______________________________________________
>> tboot-devel mailing list
>> tbo...@li...
>> https://lists.sourceforge.net/lists/listinfo/tboot-devel
> 
> 
> 
> ------------------------------
> 
> 
> 
> ------------------------------
> 
> Subject: Digest Footer
> 
> _______________________________________________
> tboot-devel mailing list
> tbo...@li...
> https://lists.sourceforge.net/lists/listinfo/tboot-devel
> 
> 
> ------------------------------
> 
> End of tboot-devel Digest, Vol 147, Issue 2
> *******************************************
>