#54 TaurusWidget use by default setAutoFillBackground=true

[Valentin Valls]

Hi,

TaurusWidget use by default setAutoFillBackground=true, which is i think not a good idea.

QWidget use setAutoFillBackground=false by default.

TaurusWidget should only be a container and should not display things by itself, if i understand it well. The problem is TaurusWidget inherite from TaurusBaseContainer which initilise this background property in updateStyle().

Then maybe it can be inhibited for TaurusWidget.

What do you think about that?

[Carlos Pascual]

Hi,

I looked into your proposed solution and I do not think it is safe to apply it (because of potential backwards-compatibility issues).

TaurusBaseContainer (and therefore TaurusWidget) select the value of autoFillBackground property depending on the value returned by getShowQuality(). This may have been a bad design choice, but it is what we have.

Widgets already inheriting from TaurusWidget (and there are many, not only in the Taurus code, but also in GUIs made by taurus users) may depend on this behaviour, so I think it is not a good idea to change it.

So I suggest that you disable it for any particular widget in which you know for sure that you do not need this behaviour. You can do it in a similar way to what you suggested for TaurusWidget, or by calling self.setShowQuality(False), whatever makes more sense.

[Tiago Coutinho]

Ticket moved from /p/sardana/tickets/141/

Can't be converted:

• _category: taurus-qt