#42 Synoptic selection using outline of object instead of ellipse

[Valentin Valls]

Hi

I dont like the use of the ellipse to display selection on the synoptic. Then i create a patch to highlight the outline of the object.

Then i would like to know what you think about. If i can merge it to Taurus and how can i do it.

Right now i create a property to set to "ellipse" or to "outline", but i think it would be better to limit the grow of the code, or the code should be refactored. I unfortunatly did not really understand the meaning of many functions relative to the selection, then i am not very happy with this patch.

Then are you interested in and can you help me?

[Valentin Valls]

Here is a screenshot. It is a little ugly cause there is an auto-zoom. The outline weight is only 4 pixels.

[Carlos Pascual]

Hi, thanks a lot for the idea and the code.

It is certainly an interesting idea.

I'll pass it to srubio (maintainer of synoptics widget so that it can check it more thoroughly). From my side only 3 comments:

• Could you please separate the format changes from the implementation changes in your patch? (I know, it is our shame not using PEP8 standards in our code yet)

• IMHO, the selection style should be a pyqtproperty of the widget (it may already be, and I may have missed it in the middle of the format changes).

• Also, the selection style should use an enumeration, rather than a string. Note: taurus.core.util.enumeration will probably be substituted by a standard enum soon, but we will provide a backwards compatibility fix.

[Valentin Valls]

Thanks for the relpy.

• Yes, just do not care about the trailing space, i will clean up the patch if it is accepted.
• Yes it is already the case.
• Thanks for pointing me that. I will redone that part

[Carlos Pascual]

Hi, I tried to apply your patch and it failed.
Can you please resubmit the patch (send it to the devel list) without the format changes and making sure that it applies cleanly into the current develop bracnh?

[Valentin Valls]

Sure. I will also fix the enum, as you request

[Carlos Pascual]

Latest patch received in devel list applied to develop branch.

BTW: I made OUTLINE the default selection style (it is so much nicer than the ellipse!

[Tiago Coutinho]

Ticket moved from /p/sardana/tickets/112/

Can't be converted:

• _category: taurus