Menu

#234 Taurus4: Clean unused modules

I['Jul16', '']
resolved
taurus4 (70)
feature-request
2016-07-19
2015-12-02
No

As part of the Taurus4 effort, I would like to clean deprecated or unused and unmaintained code.

I am not interested in a deep refactoring. Just getting rid of clearly obsolete code that can be trivially removed without affecting existing apps.

Please review the following lists and yell if you think that any of the mentioned modules should not be removed. Also feel free to suggest other removals

Already removed in taurus4-preview:

  • taurus.core.utils (deprecated since v2. substituted by taurus.core.util)
  • .qtgui.table.taurusvaluestable_ro (substituted long time ago by taurusvaluestable)
  • .qtgui.panel.taurusattributechooser (substituted long time ago by taurusmodelchooser)
  • .qtgui.panel.taurusconfigbrowser (substituted long time ago by taurusconfigeditor)

To consider for removal:

  • .qtgui.base.taurusqattribute (it was started as an experiment but AFAIK it is unused and half-implemented only)
  • .gtgui.extra_xterm (unmaintained, replaceable by qtgui.console)
  • .gtgui.gauge (requires qtcontrols which I do not think it is a publicly distributed module. AFAIK nobody uses the gauges...)
  • .qtgui.image (requires Qub which I do not think it is a publicly distributed module. Can be substituted by TaurusImage. AFAIK everybody switched to TaurusImage)
  • taurus.qt.qtopengl (empty module. Nothing implemented)
  • taurus.web (started as an experiment. AFAIK it is umaintained and may even be broken already in taurus3.6. Is anyone interested in fixing and porting it to taurus4?)

Discussion

  • Carlos Pascual

    Carlos Pascual - 2015-12-02

    On Wed 2 December 2015 10:33:34 PICCA Frederic-Emmanuel wrote:

    • .qtgui.image (requires Qub which I do not think it is a
      publicly distributed module. Can be substituted by TaurusImage.
      AFAIK everybody switched to TaurusImage)

    If I remember correctly Qub is used by MxCube to display live video
    from cameras.

    I know that MxCube uses Qub, but does it use "taurus.qt.qtgui.image"?
    If it doesn't, then it is not relevant for the removal from taurus

    This widget use the shared memory system provided with
    Lima for this purpose. Is it possible to do the same thing with
    TaurusImage ?

    I am not sure about the shared memory (i would say "no"), although there is some LIMA support implemented in the VideoImageCodec, which is used by TaurusEncodedBaseImageItem.

     
  • Carlos Pascual

    Carlos Pascual - 2016-07-04

    LAST CALL:
    If there are no "passionate objections" during today, I'll procceed to remove the following modules from taurus4 develop:

    • .gtgui.extra_xterm
    • .gtgui.gauge
    • .qtgui.image
    • taurus.qt.qtopengl
    • taurus.web
    • .qtgui.base.taurusqattribute (I will leave this for last because I recall someone saying that they may have based work on it)

    Speak now or SYFM for ever ;)

     
  • Zbigniew Reszela

    • status: waiting --> resolved
     
  • Zbigniew Reszela

    Pull request was merged into develop.

     
  • Carlos Pascual

    Carlos Pascual - 2016-07-15
    • Labels: --> taurus4
    • Category: taurus4 --> Jul16,
     
  • Carlos Pascual

    Carlos Pascual - 2016-07-19

    Note: a few more already-deprecated modules were also sneakily removed in latter commits for taurus4:

    - taurus.qt.gtgui.extra_pool (use sardana.taurus.qt.gtgui.extra_pool)
    - taurus.qt.gtgui.extra_macroexecutor (use sardana.taurus.qt.gtgui.extra_macroexecutor)
    - taurus.qt.gtgui.extra_sardana (use sardana.taurus.qt.gtgui.extra_sardana)
    - taurus.qt.uic (obsolete since SEP11)
    
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.