Re: [tauruslib-devel] [PATCH] Fix bug-142: Avoid bad stretch when using extrawidget in forms

[Zbigniew R. <zre...@ce...>]

Hi Carlos,

Thanks for the patch. I have applied it to the develop branch.

Cheers,
Zibi

On 01/20/2016 11:33 AM, cpa...@ce... wrote:
> From: cpascual <cpa...@ce...>
>
> When using a TaurusValue customized with an extra widget, the grid
> layout behaves in an unexpected way regarding to its rows/columns
> stretch (see http://sf.net/p/tauruslib/tickets/142/#f4e4/9e68).
> Prevent this by inserting a spacer in the extrawidget column if no
> extrawidget is used.
> ---
>   lib/taurus/qt/qtgui/panel/taurusvalue.py | 16 +++++++++++-----
>   1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/lib/taurus/qt/qtgui/panel/taurusvalue.py b/lib/taurus/qt/qtgui/panel/taurusvalue.py
> index 543ba0e..dff58d2 100644
> --- a/lib/taurus/qt/qtgui/panel/taurusvalue.py
> +++ b/lib/taurus/qt/qtgui/panel/taurusvalue.py
> @@ -833,11 +833,17 @@ class TaurusValue(Qt.QWidget, TaurusBaseWidget):
>                                                1, 1, -1, alignment)
>       
>       def addExtraWidgetToLayout(self):
> -        if self._extraWidget is not None and self.parent() is not None:
> -            alignment = getattr(self._extraWidget, 'layoutAlignment',
> -                                Qt.Qt.AlignmentFlag(0))
> -            self.parent().layout().addWidget(self._extraWidget, self._row,
> -                                             5, 1, 1, alignment)
> +        parent = self.parent()
> +        if parent is not None:
> +            if self._extraWidget is None:
> +                # Adding this spacer is some voodoo magic to avoid bug #142
> +                # See: http://sf.net/p/tauruslib/tickets/142/
> +                parent.layout().addItem(Qt.QSpacerItem(0, 0), self._row, 5)
> +            else:
> +                alignment = getattr(self._extraWidget, 'layoutAlignment',
> +                                    Qt.Qt.AlignmentFlag(0))
> +                parent.layout().addWidget(self._extraWidget, self._row,
> +                                            5, 1, 1, alignment)
>   
>       @Qt.pyqtSignature("parentModelChanged(const QString &)")
>       def parentModelChanged(self, parentmodel_name):

-- 

ALBA Synchrotron <http://www.albasynchrotron.es>

	Zbigniew Reszela
Controls Section - Computing Division

ALBA SYNCHROTRON LIGHT SOURCE
Carrer de la Llum 2-26 | 08290 | Cerdanyola del Vallès| Barcelona | 
Spain <http://www.albasynchrotron.es/AboutUs/Access>
(+34) 93 592 4407
www.albasynchrotron.es <http://www.albasynchrotron.es>| 
zre...@ce... <mailto:zre...@ce...>

**Please, do not print this e-mail unless it is absolutely necessary.
**Si heu rebut aquest correu per error, us informo que pot contenir 
informació confidencial i privada i que està prohibit el seu ús. Us 
agrairíem que ho comuniqueu al remitent i l'elimineu. Gràcies.
Si ha recibido este correo por error, le informo de que puede contener 
información confidencial y privada y que está prohibido su uso. Le 
agradeceré que lo comunique a su remitente y lo elimine. Gracias.
If you have received this e-mail in error, please note that it may 
contain confidential and private information, therefore, the use of this 
information is strictly forbidden. Please inform the sender of the error 
and delete the information received. Thank you.