Re: [tauruslib-devel] [PATCH] Fix bug#243 taurustrend2D menu option fails

[Carlos P. <cpa...@ce...>]

Hi, this is a duplicated solution (see #240) so I won't apply it.
Note: It also adds the check on self.plot, but I could not see how it 
affects. If you consider it important, please resubmit that part only 
with a description of what it solves.

Cheers


On Fri 18 December 2015 15:48:50 cfalcon wrote:
> The taurustrend2D setModel menu option fails. It raises a
> TaurusException with 'Invalid scheme'
> 
> The widget was developed to manage just one model and
> several inputs in the setModel menu option is configured.
> 
> Fix it, setting this menu option to a 'simple model'.
> ---
>  lib/taurus/qt/qtgui/extra_guiqwt/image.py         | 5 ++++-
>  lib/taurus/qt/qtgui/extra_guiqwt/taurustrend2d.py | 4 ++--
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/taurus/qt/qtgui/extra_guiqwt/image.py
> b/lib/taurus/qt/qtgui/extra_guiqwt/image.py index e20a766..570fbee
> 100644
> --- a/lib/taurus/qt/qtgui/extra_guiqwt/image.py
> +++ b/lib/taurus/qt/qtgui/extra_guiqwt/image.py
> @@ -258,7 +258,10 @@ class TaurusTrend2DItem(XYImageItem,
> TaurusBaseComponent): return
> 
>          plot = self.plot()
> -
> +
> +        if plot is None:
> +            return
> +
>          #initialization
>          ySize = len(evt_value.value)
>          if self._yValues is None:
> diff --git a/lib/taurus/qt/qtgui/extra_guiqwt/taurustrend2d.py
> b/lib/taurus/qt/qtgui/extra_guiqwt/taurustrend2d.py index
> 4b1ea40..9e53300 100644
> --- a/lib/taurus/qt/qtgui/extra_guiqwt/taurustrend2d.py
> +++ b/lib/taurus/qt/qtgui/extra_guiqwt/taurustrend2d.py
> @@ -62,8 +62,8 @@ class TaurusTrend2DDialog(ImageDialog,
> TaurusBaseWidget): self.setStackMode(stackMode)
>          self.setWindowFlags(Qt.Qt.Widget)
>          #add some tools
> -        for toolklass in (TaurusModelChooserTool,AutoScrollTool):
> -            self.add_tool(toolklass)
> +        self.add_tool(TaurusModelChooserTool, singleModel=True)
> +        self.add_tool(AutoScrollTool)
>          self.setModifiableByUser(self._modifiableByUser)
>          self.setContextMenuPolicy(Qt.Qt.CustomContextMenu)

-- 
+----------------------------------------------------+
 Carlos Pascual Izarra
 Scientific Software Coordinator
 Computing Division
 ALBA Synchrotron  [http://www.albasynchrotron.es]
 Carrer de la Llum 2-26
 E-08290 Cerdanyola del Valles (Barcelona), Spain
 E-mail: cpa...@ce...
 Phone: +34 93 592 4428
+----------------------------------------------------+