Re: [tauruslib-devel] [PATCH] Remove nasty sleep in taurus.Starter

[Carlos P. <cpa...@ce...>]

Patch applied to develop,

Thanks!

On Tue 26 May 2015 17:08:42 cfalcon wrote:
> The time.sleep of 3 seconds in both methods (startDs and stopDS)
> have been commented to reduce the execution time.
> These methods have been tested without reproduce the previously
> failures.
> ---
>  lib/taurus/core/tango/starter.py | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/taurus/core/tango/starter.py
> b/lib/taurus/core/tango/starter.py index 65b129e..10dd16e 100644
> --- a/lib/taurus/core/tango/starter.py
> +++ b/lib/taurus/core/tango/starter.py
> @@ -88,7 +88,9 @@ class Starter(object):
>              if self.isRunning():
>                  time.sleep(1)
>              else:
> -                time.sleep(3) #TODO: figure out why we have to wait
> here +                ## TODO: figure out why we have to wait here
> (see isRunning) +                #time.sleep(3)
> +                ##
>                  _log.info('Server %s has been stopped' %
> self.ds_name) return
>          _log.warning('Server %s did not stop within %d seconds'%
> @@ -107,7 +109,9 @@ class Starter(object):
>                        (self.ds_name, i))
>              if self.isRunning():
>                  _log.info('Server %s has been started' %
> self.ds_name) -                time.sleep(3) #TODO: figure out why we
> have to wait here +                ## TODO: figure out why we have to
> wait here (see isRunning) +                #time.sleep(3)
> +                ##
>                  return
>              else:
>                  time.sleep(1)
> @@ -173,6 +177,8 @@ class Starter(object):
> 
> 
>      def isRunning(self):
> +        # TODO: In case of we will need to add the sleep again.
> +        # We should study another implementation for this method.
>          if self.dserver is None:
>              return False
>          try:

-- 
+----------------------------------------------------+
 Carlos Pascual Izarra
 Scientific Software Coordinator
 Computing Division
 ALBA Synchrotron  [http://www.albasynchrotron.es]
 Carretera BP 1413 de Cerdanyola-Sant Cugat, Km. 3.3
 E-08290 Cerdanyola del Valles (Barcelona), Spain
 E-mail: cpa...@ce...
 Phone: +34 93 592 4428
+----------------------------------------------------+