Re: [Taskforest-discuss] `make test` failures?

[Aijaz A. <en...@us...>]

Steve:

I can confirm that there was a problem with the test cases (as opposed to
the actual program).  I've fixed the test cases, and the scenario you were
describing works now.  There's an unofficial version 1.34 available at
http://www.taskforest.com/TaskForest-1.34.tar.gz

It's unofficial because I had already been working on version 1.34 and it's
got a few other enhancements, including the ability to put a job on hold and
release a hold off a job.  I haven't finished working on the documentation
of these new features and don't want to release the code officially until
the user documentation is done.  I expect it will take a few more days to
complete the docs.  If you would like to, feel free to download 1.34 and
test it out.  I'll release the official version as 1.35.

Thanks again for your help in debugging this.

Aijaz.

On Tue, Feb 2, 2010 at 11:19 AM, Aijaz Ansari
<en...@us...>wrote:

> Excellent detective work.  Thanks, Steve.  My comments are interspersed
> below.
>
> On Tue, Feb 2, 2010 at 10:55 AM, Steve Hulet <st...@id...> wrote:
> ...
>
>>
>> Now for the news: running the exact same commands this morning (`perl
>> Makefile.PL`, `make`, & `make test`) does *not* result in the same
>> failures experienced last night. That is, all of the tests pass,
>> *until* t/025_Midnight_Ready, which still hangs.
>>
>
> I think the test case has a bug.  The code uses its own function (called
> LocalTime, I think) that returns the current time.  That way during testing
> I can change the 'current time' so that I can test how the program would
> behave in the future.  I think t/025_Midnight_Ready may not be using that
> function, and therefore must be confused about what day it is.  I can test
> that out pretty easily.
>
>
>>
>> Interestingly, between 10pm and midnight PST and CST are on different
>> days. Could this have caused the other `make test` failures?
>>
>
> Yes. I'm pretty sure that's it.  I think (hope) it's just a bug in the test
> code and not in the actual program itself.  I'll verify that over the next
> day or two.  It will take me a few days to  get the new release out
> officially, but I'll let you know what I find as I go along.
>
>
>>
>> Looking inside t/families/MIDNIGHT I see:
>>
>>
>> start => '00:00', tz=>'GMT', days => 'Mon,Tue,Wed,Thu,Fri,Sat,Sun'
>>
>> J_005( start=>'04:59')  # 11:59pm Chicago time April 19 2009
>>
>>
>> Based on the comment this test appears to make the assumption that
>> 4:59 GMT is 11:59pm Chicago time. While this was true April 19, 2009
>> it is not true today due to Daylight Savings Time not being in effect.
>>
>> 2009-04-09:
>> http://timeanddate.com/worldclock/converted.html?month=4&day=19&year=2009&hour=4&min=55&sec=0&p1=0&p2=64
>> 2010-02-02<http://timeanddate.com/worldclock/converted.html?month=4&day=19&year=2009&hour=4&min=55&sec=0&p1=0&p2=64%0A2010-02-02>:
>>
>> http://timeanddate.com/worldclock/converted.html?month=2&day=2&year=2010&hour=4&min=55&sec=0&p1=0&p2=64
>>
>> Could this have caused t/025_Midnight_Ready to hang?
>>
>
> I think this is ok.  I don't have the code in front of me, but if I
> remember correctly, the test case sets the 'current time' to some time on
> 4/19/2009 (Chicago time).   I'll double check this.
>
> You've given me all the information I need to be able to duplicate this at
> home and determine whether there's a bug in the test program or in the
> taskforest code itself, or both.
>
> As for the failure of the taskforestd daemon test, that's probably not
> related, but I'll gladly help you get that running once these other issues
> are resolved.
>
> Thanks again,
>
> Aijaz.
>
>
>>
>> Thanks,
>>  steve
>>
>>
>>
>> On Tue, Feb 2, 2010 at 6:17 AM, Aijaz Ansari
>> <en...@us...> wrote:
>> > Steve:
>> >
>> > Thanks for  your detailed email.  There may be a problem with the test
>> case
>> > or something unexpected in  your setup.  I'll try to duplicate this on
>> my
>> > end.  Could you please answer these questions for me?  It might help
>> > identify the problem.
>> >
>> > What time zone is your computer set at, and at what time were you
>> running
>> > these tests?  It really shouldn't matter, but it may help identify the
>> > problem.
>> >
>> > Were you attempting to install via CPAN or did you download the package
>> and
>> > and manually type in perl Makefile.PL, make and make test?
>> >
>> > Did the linux user you were logged in as have write permission to the
>> > current directory you were in?
>> >
>> > Thanks,
>> >
>> > Aijaz.
>> >
>> >
>> > On Tue, Feb 2, 2010 at 1:23 AM, Steve Hulet <st...@id...>
>> wrote:
>> >>
>> >> Hi,
>> >>
>> >> I just downloaded Task Forest 1.33 with high hopes and great
>> >> expectations--I've been looking for a simple yet powerful
>> >> text-file-based job scheduler of this sort for a long time.
>> >>
>> >> I ran `perl Makefile.PL`, `make`, and `make test` but many of the unit
>> >> test fail and t/025_Midnight_Ready hangs after printing 1/19. Is this
>> >> expected? Did I miss a setup or configuration step?
>> >>
>> >> I'm running perl v5.10.0 on Linux version 2.6.31-17-generic (Ubuntu
>> >> 9.10). `make test` output included below.
>> >>
>> >> Thanks,
>> >>  steve
>> >>
>> >
>> > <snip>
>>
>
>