The pogo preferences common_target.opt has a bug when you use it to compile libraries. The target dirrectories does not build the directories for lib_objs. I attached a patch.
I recently sent a patch to allow to skip unneccessary rebuilds and this changed common_target.opt.
It looks like your patch is not based on the latest svn version of common_target.opt.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
You are right, I used the tango 9.1.0 tar file as source. I used it locally and the patch has to be adapted in the future to be integrated in the trunk.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi Carlos,
Thanks for the PR. Your contribution will be taken into account in the next version of the source distribution.
Tango 9.2.5a source distribution was prepared from Sourceforge SVN and the changes made since 9.2.2 have not been committed on GitHub yet.
The GitHub version is currently a bit behind the one on Sourceforge.
It might actually be easier to remove the TangoSourceDistribution GitHub repository and create it again from the svn Sourceforge repo. We need to ensure your change is not lost in the meantime... So we could commit it in Sourceforge or add it after the new migration on GitHub.
The next Tango Source distribution will be prepared from GitHub.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I just deleted the TangoSourceDistribution GitHub repository and created it again in order to get automatically all the changes which were done for Tango 9.2.5a. So now we can work on this Github repository.
Your PR got removed in the process.
Could you please create it again? https://github.com/tango-controls/TangoSourceDistribution/pulls
Here is the text of the PR you created before (Fix directories variable initialization):
Directories variable is not well created for Library projects or
multiple projects (DS + Library) since they normally defined $LIB_OBJS
instead of $SVC_OBJS for building the libraries.
Create directories variable using also $LIB_OBJS variable
I'm sorry for the inconvenience.
If you don't want to do it, I could also do it if you prefer.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I recently sent a patch to allow to skip unneccessary rebuilds and this changed common_target.opt.
It looks like your patch is not based on the latest svn version of common_target.opt.
You are right, I used the tango 9.1.0 tar file as source. I used it locally and the patch has to be adapted in the future to be integrated in the trunk.
I attached a patch for 9.2.1.
Your new patch looks good to me.
I also did a "PR":https://github.com/tango-controls/TangoSourceDistribution/pulls some weeks ago, but I don't know if it is the right place.
Hi Carlos,
Thanks for the PR. Your contribution will be taken into account in the next version of the source distribution.
Tango 9.2.5a source distribution was prepared from Sourceforge SVN and the changes made since 9.2.2 have not been committed on GitHub yet.
The GitHub version is currently a bit behind the one on Sourceforge.
It might actually be easier to remove the TangoSourceDistribution GitHub repository and create it again from the svn Sourceforge repo. We need to ensure your change is not lost in the meantime... So we could commit it in Sourceforge or add it after the new migration on GitHub.
The next Tango Source distribution will be prepared from GitHub.
Hi Carlos,
I just deleted the TangoSourceDistribution GitHub repository and created it again in order to get automatically all the changes which were done for Tango 9.2.5a. So now we can work on this Github repository.
Your PR got removed in the process.
Could you please create it again? https://github.com/tango-controls/TangoSourceDistribution/pulls
Here is the text of the PR you created before (Fix directories variable initialization):
I'm sorry for the inconvenience.
If you don't want to do it, I could also do it if you prefer.
Done!! Here is the PR
Thanks so much