Menu

#781 [tango 9.2.0a] problem with update_db8.sql.in

open
nobody
None
Source distribution
1
2016-02-29
2016-02-26
No

Hello,

While preparing the tango 9.2.0 debian package, I saw an issue with the update_db8.sql.in file.
This file contain these lines.

source stored_proc.sql

BUT the distributed stored_proc.sql is the one from 9.2.0 and not the one distributed with the previous 9.1.0.

this means that applying update_db8.sql from the 9.2.0 source

doesn not have the the same effect than applying the

update_db.sql script from the 9.1.0 source.

for this time this is not such an issue because the the update_db.sql.in of 9.2.0 contain only a source of the stored_proc.sql. but who knows...

Nevertheless playing with these upgrade scripts is not that easy and really error prone for packagers.

so will it be possible to change the naming of all these scripts with something more resiliant to this kind of errors.

why not versionning also the stored procedure

update_db_<version>.sql.in
stored_proc_<version>.sql.in

in order to avoid this problem ?

Cheers

Frederic

Discussion

  • Emmanuel Taurel

    Emmanuel Taurel - 2016-02-29

    Hi Fred,

    I don't understand your problem. The script updating the stored procedure first destoy the
    installed ones and then re-create the new procedures to their last releases. Therefore, coming from a Tango 7, 8 or 9.1
    does not have any impact here. A file named stored_proc_8.sql.in will be exactly the same than the
    file stored_proc_9.sql

    Cheers

    Emmanuel

     
  • Frédéric PICCA

    Hello manu

    This is just that next time you will have a stored_proc.sql (for the 10 version). This one will be different than the current stored_proc.sql (9 version) BUT
    the update_db8.sql source a non-versionned stored_proc.sql

    So the update_db8.sql will install the stored_proc (10 version) instead of the 9 one.

    Is it clearer ?

    Fred

     
  • Emmanuel Taurel

    Emmanuel Taurel - 2016-02-29

    Re,

    But this is what we want no?
    If you update your Tango installation, you want the last release of the stored procedures even if you had Tango 8 before.

    Manu

     

Log in to post a comment.