#7 Use of uninitialized value in &MP3::Tag::ID3v2::TCON

[Tim Hunter]

Another minor bug from my mp3 perusal:

Use of uninitialized value in substitution iterator at
/usr/lib/perl5/site_perl/5.8.5/MP3/Tag/ID3v2.pm line 1575.
TCON: (Content type)

It turns out that the value of TCON is (127), which is
outside the defined range of values that
&MP3::Tag::ID3v1::genres knows about. May I suggest
the following patch?

% diff -u ID3v2.pm.orig ID3v2.pm
--- ID3v2.pm.orig 2004-08-23 17:58:33.015005500 +0100
+++ ID3v2.pm 2004-08-23 21:41:01.743983500 +0100
@@ -1572,7 +1572,10 @@
}
# called by extract_data
if ($data =~ /\((\d+)\)/) {
- $data =~ s/\((\d+)\)/MP3::Tag::ID3v1::genres($1)/e;
+ my $v1genre = MP3::Tag::ID3v1::genres($1);
+ if (defined($v1genre)) {
+ $data =~ s/\((\d+)\)/$v1genre/;
+ }
}
return $data;
}