syntekdriver-devel — Development discussion mailing list

[Syntekdriver-devel] Question about documentation

[Sławomir K. <sla...@gm...>]

Hi,

I want to check code and improve it as this driver doesn't work good with
my webcam on my Laptop ASUS F5R.

I browse code and see that there is lot registry sets.
Can you provide any documentation for this?

Pozdrawiam
Sławomir Kowalewski

[Syntekdriver-devel] Support for Syntec DC 1120?

[Satz K. <sat...@go...>]

Hi,

I have a camera that uses the Syntec DC 1120 chip (instead of 1125).
Simply changing the vendor and product ID in sources for the DC 1125
variant did not do the job - so it seems there are some differences.

Until now I was not able to run one of the USB-sniffers under Windows
7 so I can't provide a logfile.

So...any idea how I could help or what I could check to get this camera working?

Thanks!

Elmi

[Syntekdriver-devel] New branche 2.x.x and new trunk for kernel 2.6.38 and higher

[Nicolas <pr...@fr...>]

Hi,

I have added some fixes for kernel 2.6.38 and higher.

I have removed V4L1 support in the trunk since it's removed from the
kernel tree.

We can continue to use 2.x.x branche for the old kernel.

Regards,

Nicolas

[Syntekdriver-devel] [PATCH 9/9] stk11xx: Add install target to Makefile.standalone

[Peter S. <pe...@st...>]

Run make -f Makefile.standalone install to build and install the module.

Signed-off-by: Peter Stuge <pe...@st...>
---
 Makefile.standalone |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/Makefile.standalone b/Makefile.standalone
index ff375b1..8ad72b3 100644
--- a/Makefile.standalone
+++ b/Makefile.standalone
@@ -13,6 +13,9 @@ driver:
 	$(MAKE) -C $(KSRC) SUBDIRS=$(PWD) modules
 	@ctags -R
 
+install: driver
+	$(MAKE) -C $(KSRC) SUBDIRS=$(PWD) modules_install
+
 clean:
 	$(MAKE) -C $(KSRC) SUBDIRS=$(PWD) clean
 	@rm -f Module.symvers
-- 
1.7.0.4

[Syntekdriver-devel] [PATCH 4/9] stk11xx: Make messages about unconfirmed watchdog registers use STK_DEBUG

[Peter S. <pe...@st...>]

Apparently reading the register in question can also return 2, which
meant that using STK_ERROR produced copious output during normal use.

This problem was originally brought up at
http://sourceforge.net/tracker/?func=detail&aid=3201289&group_id=178178&atid=884193

Signed-off-by: Peter Stuge <pe...@st...>
---
 stk11xx-dev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/stk11xx-dev.c b/stk11xx-dev.c
index 93ca569..e6600a0 100644
--- a/stk11xx-dev.c
+++ b/stk11xx-dev.c
@@ -238,7 +238,7 @@ int dev_stk11xx_watchdog_camera(struct usb_stk11xx *dev)
 	usb_stk11xx_read_registry(dev, 0x0001, &value);
 
 	if (value != 0x03) {
-		STK_ERROR("Error : Register 0x0001 = %02X\n", value);
+		STK_DEBUG("Error : Register 0x0001 = %02X\n", value);
 	}
 
 	return value;
-- 
1.7.0.4

[Syntekdriver-devel] [PATCH 6/9] stk11xx: Add horizontal and vertical flip controls

[Peter S. <pe...@st...>]

From: Cristi Posoiu <cri...@gm...>

This patch was taken from
http://sourceforge.net/tracker/?func=detail&aid=3201636&group_id=178178&atid=884193

Signed-off-by: Peter Stuge <pe...@st...>
---
 stk11xx-usb.c |    2 ++
 stk11xx-v4l.c |   40 ++++++++++++++++++++++++++++++++++++++++
 stk11xx.h     |    2 ++
 3 files changed, 44 insertions(+), 0 deletions(-)

diff --git a/stk11xx-usb.c b/stk11xx-usb.c
index c065aab..3494c0a 100644
--- a/stk11xx-usb.c
+++ b/stk11xx-usb.c
@@ -695,6 +695,8 @@ static int usb_stk11xx_default_settings(struct usb_stk11xx *dev)
 	dev->vsettings.default_whiteness = dev->vsettings.whiteness;
 	dev->vsettings.default_contrast = dev->vsettings.contrast;
 	dev->vsettings.default_colour = dev->vsettings.colour;
+	dev->vsettings.default_hflip = dev->vsettings.hflip;
+	dev->vsettings.default_vflip = dev->vsettings.vflip;
 
 	return 0;
 }
diff --git a/stk11xx-v4l.c b/stk11xx-v4l.c
index 69b2e23..0ddd345 100644
--- a/stk11xx-v4l.c
+++ b/stk11xx-v4l.c
@@ -122,6 +122,24 @@ static struct v4l2_queryctrl stk11xx_controls[] = {
 		.step    = 1,
 		.default_value = 0x7f00,
 	},
+	{
+		.id      = V4L2_CID_HFLIP,
+		.type    = V4L2_CTRL_TYPE_BOOLEAN,
+		.name    = "Flip Horizontally",
+		.minimum = 0,
+		.maximum = 1,
+		.step    = 1,
+		.default_value = 0, // will be actually set later
+	},
+	{
+		.id      = V4L2_CID_VFLIP,
+		.type    = V4L2_CTRL_TYPE_BOOLEAN,
+		.name    = "Flip Vertically",
+		.minimum = 0,
+		.maximum = 1,
+		.step    = 1,
+		.default_value = 0, // will be actually set later
+	}
 };
 
 
@@ -1115,6 +1133,12 @@ static long v4l_stk11xx_do_ioctl(struct file *fp,
 							case V4L2_CID_CONTRAST:
 								c->default_value = dev->vsettings.default_contrast;
 								break;
+							case V4L2_CID_HFLIP:
+								c->default_value = dev->vsettings.default_hflip;
+								break;
+							case V4L2_CID_VFLIP:
+								c->default_value = dev->vsettings.default_vflip;
+								break;
 						}
 						break;
 					}
@@ -1152,6 +1176,14 @@ static long v4l_stk11xx_do_ioctl(struct file *fp,
 						c->value = dev->vsettings.contrast;
 						break;
 
+					case V4L2_CID_HFLIP:
+						c->value = dev->vsettings.hflip;
+						break;
+
+					case V4L2_CID_VFLIP:
+						c->value = dev->vsettings.vflip;
+						break;
+
 					default:
 						return -EINVAL;
 				}
@@ -1181,6 +1213,14 @@ static long v4l_stk11xx_do_ioctl(struct file *fp,
 						dev->vsettings.contrast = (0xff00 & c->value);
 						break;
 
+					case V4L2_CID_HFLIP:
+						dev->vsettings.hflip = c->value ? 1: 0;
+						break;
+
+					case V4L2_CID_VFLIP:
+						dev->vsettings.vflip = c->value ? 1: 0;
+						break;
+
 					default:
 						return -EINVAL;
 				}
diff --git a/stk11xx.h b/stk11xx.h
index 719d2fb..338ae68 100644
--- a/stk11xx.h
+++ b/stk11xx.h
@@ -305,6 +305,8 @@ struct stk11xx_video {
 	int default_contrast;
 	int default_colour;
 	int default_whiteness;
+	int default_hflip;
+	int default_vflip;
 };
 
 
-- 
1.7.0.4

[Syntekdriver-devel] [PATCH 2/9] stk11xx: Fix race condition in v4l_stk11xx_open()

[Peter S. <pe...@st...>]

From: Cristi Posoiu <cri...@gm...>

The mutex should be locked already before checking if the device is open.

This should fix
https://sourceforge.net/tracker/index.php?func=detail&aid=3187007&group_id=178178&atid=884191

This patch was originally published at
http://sourceforge.net/tracker/?func=detail&aid=3201155&group_id=178178&atid=884193

Signed-off-by: Peter Stuge <pe...@st...>
---
 stk11xx-v4l.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/stk11xx-v4l.c b/stk11xx-v4l.c
index e67f56a..d04bc04 100644
--- a/stk11xx-v4l.c
+++ b/stk11xx-v4l.c
@@ -302,13 +302,14 @@ static int v4l_stk11xx_open(struct file *fp)
 		BUG();
 	}
 
+	mutex_lock(&dev->modlock);
+
 	if (dev->vopen) {
 		STK_DEBUG("Device is busy, someone is using the device\n");
+		mutex_unlock(&dev->modlock);
 		return -EBUSY;
 	}
 
-	mutex_lock(&dev->modlock);
-
 	// Allocate memory
 	err = stk11xx_allocate_buffers(dev);
 
-- 
1.7.0.4

[Syntekdriver-devel] [PATCH 8/9] stk11xx: Do not implement v4l ioctls when v4l is not available

[Peter S. <pe...@st...>]

Linux 2.6.38 removes the deprecated v4l interface, so the driver should
not implement it anymore.

Signed-off-by: Peter Stuge <pe...@st...>
---
 stk11xx-sysfs.c |    2 ++
 stk11xx-v4l.c   |    4 ++++
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/stk11xx-sysfs.c b/stk11xx-sysfs.c
index a9779c9..2ce6f7a 100644
--- a/stk11xx-sysfs.c
+++ b/stk11xx-sysfs.c
@@ -40,7 +40,9 @@
 #include <linux/kref.h>
 #include <linux/device.h>
 #include <linux/mm.h>
+#if defined(VIDIOCGCAP)
 #include <linux/videodev.h>
+#endif
 
 
 #include <linux/usb.h>
diff --git a/stk11xx-v4l.c b/stk11xx-v4l.c
index 0ddd345..2132cfa 100644
--- a/stk11xx-v4l.c
+++ b/stk11xx-v4l.c
@@ -40,7 +40,9 @@
 #include <linux/kref.h>
 #include <linux/vmalloc.h>
 #include <linux/mm.h>
+#if defined(VIDIOCGCAP)
 #include <linux/videodev.h>
+#endif
 
 
 #include <linux/usb.h>
@@ -683,6 +685,7 @@ static long v4l_stk11xx_do_ioctl(struct file *fp,
 #endif
 
 	switch (cmd) {
+#ifdef VIDIOCGCAP
 		// Video 4 Linux v1
 
 		case VIDIOCGCAP:
@@ -1024,6 +1027,7 @@ static long v4l_stk11xx_do_ioctl(struct file *fp,
 				vu->teletext = -1;
 			}
 			break;
+#endif /* VIDIOCGCAP */
 
 
 		// Video 4 Linux v2
-- 
1.7.0.4

[Syntekdriver-devel] [PATCH 1/9] stk11xx: Make VIDIOC_TRY_FMT and VIDIOC_S_FMT return more complete format info

[Peter S. <pe...@st...>]

From: Cristi Posoiu <cri...@gm...>

In particular this fixes crashes in libv4l and libv4lconvert because the
driver should fill more fields in the data structure returned by the ioctls.

This patch was originally published at
http://sourceforge.net/tracker/?func=detail&aid=3200819&group_id=178178&atid=884193

Signed-off-by: Peter Stuge <pe...@st...>
---
 stk11xx-v4l.c |   64 +++++++++++++++++++++++++++++++++++++++-----------------
 1 files changed, 44 insertions(+), 20 deletions(-)

diff --git a/stk11xx-v4l.c b/stk11xx-v4l.c
index 8ed04d7..e67f56a 100644
--- a/stk11xx-v4l.c
+++ b/stk11xx-v4l.c
@@ -1307,26 +1307,6 @@ static long v4l_stk11xx_do_ioctl(struct file *fp,
 				if (fmtd->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
 					return -EINVAL;
 
-				switch (fmtd->fmt.pix.pixelformat) {
-					case V4L2_PIX_FMT_RGB24:
-					case V4L2_PIX_FMT_BGR24:
-						dev->vsettings.depth = 24;
-						break;
-
-					case V4L2_PIX_FMT_RGB32:
-					case V4L2_PIX_FMT_BGR32:
-						dev->vsettings.depth = 32;
-						break;
-
-					case V4L2_PIX_FMT_UYVY:
-					case V4L2_PIX_FMT_YUYV:
-						dev->vsettings.depth = 16;
-						break;
-
-					default:
-						return -EINVAL;
-				}
-
 				switch (dev->webcam_type) {
 					case STK11XX_SXGA:
 						if (fmtd->fmt.pix.width > stk11xx_image_sizes[STK11XX_1280x1024].x)
@@ -1365,6 +1345,34 @@ static long v4l_stk11xx_do_ioctl(struct file *fp,
 						break;
 				}
 
+				fmtd->fmt.pix.field = V4L2_FIELD_NONE;
+				fmtd->fmt.pix.colorspace = V4L2_COLORSPACE_SRGB;
+				fmtd->fmt.pix.priv = 0;
+				switch (fmtd->fmt.pix.pixelformat) {
+					case V4L2_PIX_FMT_RGB24:
+					case V4L2_PIX_FMT_BGR24:
+						dev->vsettings.depth = 24;
+						fmtd->fmt.pix.sizeimage = fmtd->fmt.pix.width * fmtd->fmt.pix.height * 3;
+						fmtd->fmt.pix.bytesperline = 3 * fmtd->fmt.pix.width;
+						break;
+
+					case V4L2_PIX_FMT_RGB32:
+					case V4L2_PIX_FMT_BGR32:
+						dev->vsettings.depth = 32;
+						fmtd->fmt.pix.sizeimage = fmtd->fmt.pix.width * fmtd->fmt.pix.height * 4;
+						fmtd->fmt.pix.bytesperline = 4 * fmtd->fmt.pix.width;
+						break;
+
+					case V4L2_PIX_FMT_UYVY:
+					case V4L2_PIX_FMT_YUYV:
+						dev->vsettings.depth = 16;
+						fmtd->fmt.pix.sizeimage = fmtd->fmt.pix.width * fmtd->fmt.pix.height * 2;
+						fmtd->fmt.pix.bytesperline = 2 * fmtd->fmt.pix.width;
+						break;
+
+					default:
+						return -EINVAL;
+				}
 			}
 			break;
 
@@ -1377,35 +1385,51 @@ static long v4l_stk11xx_do_ioctl(struct file *fp,
 				if (fmtd->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
 					return -EINVAL;
 
+				fmtd->fmt.pix.field = V4L2_FIELD_NONE;
+				fmtd->fmt.pix.colorspace = V4L2_COLORSPACE_SRGB;
+				fmtd->fmt.pix.priv = 0;
+
 				switch (fmtd->fmt.pix.pixelformat) {
 					case V4L2_PIX_FMT_RGB24:
 						dev->vsettings.depth = 24;
 						dev->vsettings.palette = STK11XX_PALETTE_RGB24;
+						fmtd->fmt.pix.sizeimage = fmtd->fmt.pix.width * fmtd->fmt.pix.height * 3;
+						fmtd->fmt.pix.bytesperline = 3 * fmtd->fmt.pix.width;
 						break;
 
 					case V4L2_PIX_FMT_RGB32:
 						dev->vsettings.depth = 32;
 						dev->vsettings.palette = STK11XX_PALETTE_RGB32;
+						fmtd->fmt.pix.sizeimage = fmtd->fmt.pix.width * fmtd->fmt.pix.height * 4;
+						fmtd->fmt.pix.bytesperline = 4 * fmtd->fmt.pix.width;
 						break;
 
 					case V4L2_PIX_FMT_BGR24:
 						dev->vsettings.depth = 24;
 						dev->vsettings.palette = STK11XX_PALETTE_BGR24;
+						fmtd->fmt.pix.sizeimage = fmtd->fmt.pix.width * fmtd->fmt.pix.height * 3;
+						fmtd->fmt.pix.bytesperline = 3 * fmtd->fmt.pix.width;
 						break;
 
 					case V4L2_PIX_FMT_BGR32:
 						dev->vsettings.depth = 32;
 						dev->vsettings.palette = STK11XX_PALETTE_BGR32;
+						fmtd->fmt.pix.sizeimage = fmtd->fmt.pix.width * fmtd->fmt.pix.height * 4;
+						fmtd->fmt.pix.bytesperline = 4 * fmtd->fmt.pix.width;
 						break;
 
 					case V4L2_PIX_FMT_UYVY:
 						dev->vsettings.depth = 16;
 						dev->vsettings.palette = STK11XX_PALETTE_UYVY;
+						fmtd->fmt.pix.sizeimage = fmtd->fmt.pix.width * fmtd->fmt.pix.height * 2;
+						fmtd->fmt.pix.bytesperline = 2 * fmtd->fmt.pix.width;
 						break;
 
 					case V4L2_PIX_FMT_YUYV:
 						dev->vsettings.depth = 16;
 						dev->vsettings.palette = STK11XX_PALETTE_YUYV;
+						fmtd->fmt.pix.sizeimage = fmtd->fmt.pix.width * fmtd->fmt.pix.height * 2;
+						fmtd->fmt.pix.bytesperline = 2 * fmtd->fmt.pix.width;
 						break;
 
 					default:
-- 
1.7.0.4

[Syntekdriver-devel] [PATCH 7/9] stk11xx: Attempt to fix system lockup on rmmod + modprobe of driver

[Peter S. <pe...@st...>]

From: Cristi Posoiu <cri...@gm...>

Unfortunately it seems that this change does not solve the problem.

This patch was taken from
http://sourceforge.net/tracker/?func=detail&aid=3201636&group_id=178178&atid=884193

Signed-off-by: Peter Stuge <pe...@st...>
---
 stk11xx-usb.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/stk11xx-usb.c b/stk11xx-usb.c
index 3494c0a..59a4362 100644
--- a/stk11xx-usb.c
+++ b/stk11xx-usb.c
@@ -976,8 +976,6 @@ static void usb_stk11xx_disconnect(struct usb_interface *interface)
 
 	STK_INFO("Syntek USB2.0 Camera disconnected\n");
 
-	usb_set_intfdata(interface, NULL);
-
 	// We got unplugged; this is signalled by an EPIPE error code
 	if (dev->vopen) {
 		STK_INFO("Disconnected while webcam is in use !\n");
@@ -996,6 +994,9 @@ static void usb_stk11xx_disconnect(struct usb_interface *interface)
 
 	// Unregister the video device
 	v4l_stk11xx_unregister_video_device(dev);
+
+	usb_set_intfdata(interface, NULL);
+	kfree(dev);
 }
 
 #ifdef CONFIG_PM
-- 
1.7.0.4

[Syntekdriver-devel] [PATCH 3/9] stk11xx: Fix hard system crash on resume from suspend

[Peter S. <pe...@st...>]

From: Cristi Posoiu <cri...@gm...>

This patch was originally published at
http://sourceforge.net/tracker/?func=detail&aid=3201289&group_id=178178&atid=884193

Signed-off-by: Peter Stuge <pe...@st...>
---
 stk11xx-usb.c |   67 ++++++++++++++++++++++++++++++++++-----------------------
 stk11xx-v4l.c |    4 +-
 2 files changed, 42 insertions(+), 29 deletions(-)

diff --git a/stk11xx-usb.c b/stk11xx-usb.c
index a51cc5b..e952256 100644
--- a/stk11xx-usb.c
+++ b/stk11xx-usb.c
@@ -991,24 +991,30 @@ static void usb_stk11xx_disconnect(struct usb_interface *interface)
 	v4l_stk11xx_unregister_video_device(dev);
 }
 
-/*
+#ifdef CONFIG_PM
 int usb_stk11xx_suspend(struct usb_interface *interface, pm_message_t message)
 {
 	struct usb_stk11xx *dev = usb_get_intfdata(interface);
 
 	STK_INFO("Syntek USB2.0 Camera Suspend\n");
 
-	// Stop the video stream
-	dev_stk11xx_stop_stream(dev);
-			
-	// ISOC and URB cleanup
-	usb_stk11xx_isoc_cleanup(dev);
+	mutex_lock(&dev->modlock);
+	if (dev->vopen) {
+		// Stop the video stream
+		dev_stk11xx_stop_stream(dev);
 
-	// Free memory
-//	stk11xx_free_buffers(dev);
+		// ISOC and URB cleanup
+		usb_stk11xx_isoc_cleanup(dev);
 
-	// Switch off the camera
-	dev_stk11xx_camera_off(dev);
+		// Free memory
+		//	stk11xx_free_buffers(dev);
+
+		// Switch off the camera
+		dev_stk11xx_camera_off(dev);
+
+		dev_stk11xx_camera_asleep(dev);
+	}
+	mutex_unlock(&dev->modlock);
 
 	return 0;
 }
@@ -1020,32 +1026,37 @@ int usb_stk11xx_resume(struct usb_interface *interface)
 
 	STK_INFO("Syntek USB2.0 Camera Resume\n");
 
+	mutex_lock(&dev->modlock);
+
 	// Initialize the camera
 	dev_stk11xx_initialize_device(dev);
 
-	// Select the new video mode
-	v4l_stk11xx_select_video_mode(dev, dev->view.x, dev->view.y);
+	if (dev->vopen) {
+		// Select the video mode
+		v4l_stk11xx_select_video_mode(dev, dev->view.x, dev->view.y);
 
-	// Clear the buffers
-	stk11xx_clear_buffers(dev);
+		// Clear the buffers
+		stk11xx_clear_buffers(dev);
 
-	// Initialize the device
-	dev_stk11xx_init_camera(dev);
-	dev_stk11xx_camera_on(dev);
-	dev_stk11xx_reconf_camera(dev);
+		// Initialize the device
+		dev_stk11xx_init_camera(dev);
+		dev_stk11xx_camera_on(dev);
+		dev_stk11xx_reconf_camera(dev);
 
-	// ISOC and URB init
-	usb_stk11xx_isoc_init(dev);
+		// ISOC and URB init
+		usb_stk11xx_isoc_init(dev);
 
-	// Start the video stream
-	dev_stk11xx_start_stream(dev);
+		// Start the video stream
+		dev_stk11xx_start_stream(dev);
 
-	// Video settings
-	dev_stk11xx_camera_settings(dev);
+		// Video settings
+		dev_stk11xx_camera_settings(dev);
+	}
+	mutex_unlock(&dev->modlock);
 
 	return 0;
 }
-*/
+#endif /* CONFIG_PM */
 
 
 /**
@@ -1058,8 +1069,10 @@ static struct usb_driver usb_stk11xx_driver = {
 	.probe = usb_stk11xx_probe,
 	.disconnect = usb_stk11xx_disconnect,
 	.id_table = stk11xx_table,
-//	.suspend = usb_stk11xx_suspend,
-//	.resume = usb_stk11xx_resume,
+#ifdef CONFIG_PM
+	.suspend = usb_stk11xx_suspend,
+	.resume = usb_stk11xx_resume,
+#endif
 };
 
 
diff --git a/stk11xx-v4l.c b/stk11xx-v4l.c
index d04bc04..aa23115 100644
--- a/stk11xx-v4l.c
+++ b/stk11xx-v4l.c
@@ -360,7 +360,7 @@ static int v4l_stk11xx_open(struct file *fp)
 	dev_stk11xx_camera_settings(dev);
 
 	// Register interface on power management
-//	usb_autopm_get_interface(dev->interface);
+	usb_autopm_get_interface(dev->interface);
 
 	dev->vopen++;
 	fp->private_data = vdev;
@@ -406,7 +406,7 @@ static int v4l_stk11xx_release(struct file *fp)
 	dev_stk11xx_camera_asleep(dev);
 
 	// Unregister interface on power management
-//	usb_autopm_put_interface(dev->interface);
+	usb_autopm_put_interface(dev->interface);
 
 	dev->vopen--;
 
-- 
1.7.0.4

[Syntekdriver-devel] [PATCH 5/9] stk11xx: Set .default_value for controls based on values from device

[Peter S. <pe...@st...>]

From: Cristi Posoiu <cri...@gm...>

This patch was taken from
http://sourceforge.net/tracker/?func=detail&aid=3201636&group_id=178178&atid=884193

Signed-off-by: Peter Stuge <pe...@st...>
---
 stk11xx-usb.c |    5 +++++
 stk11xx-v4l.c |   16 ++++++++++++++++
 stk11xx.h     |    6 ++++++
 3 files changed, 27 insertions(+), 0 deletions(-)

diff --git a/stk11xx-usb.c b/stk11xx-usb.c
index e952256..c065aab 100644
--- a/stk11xx-usb.c
+++ b/stk11xx-usb.c
@@ -691,6 +691,11 @@ static int usb_stk11xx_default_settings(struct usb_stk11xx *dev)
 			return -1;
 	}
 
+	dev->vsettings.default_brightness = dev->vsettings.brightness;
+	dev->vsettings.default_whiteness = dev->vsettings.whiteness;
+	dev->vsettings.default_contrast = dev->vsettings.contrast;
+	dev->vsettings.default_colour = dev->vsettings.colour;
+
 	return 0;
 }
 
diff --git a/stk11xx-v4l.c b/stk11xx-v4l.c
index aa23115..69b2e23 100644
--- a/stk11xx-v4l.c
+++ b/stk11xx-v4l.c
@@ -74,6 +74,7 @@ const struct stk11xx_coord stk11xx_image_sizes[STK11XX_NBR_SIZES] = {
 /**
  * @var stk11xx_controls
  *   List of all V4Lv2 controls supported by the driver
+ *   default_value field will be overridden at runtime
  */
 static struct v4l2_queryctrl stk11xx_controls[] = {
 	{
@@ -1100,6 +1101,21 @@ static long v4l_stk11xx_do_ioctl(struct file *fp,
 					if (stk11xx_controls[i].id == c->id) {
 						STK_DEBUG("VIDIOC_QUERYCTRL found\n");
 						memcpy(c, &stk11xx_controls[i], sizeof(struct v4l2_queryctrl));
+						switch(c->id)
+						{
+							case V4L2_CID_BRIGHTNESS:
+								c->default_value = dev->vsettings.default_brightness;
+								break;
+							case V4L2_CID_WHITENESS:
+								c->default_value = dev->vsettings.default_whiteness;
+								break;
+							case V4L2_CID_SATURATION:
+								c->default_value = dev->vsettings.default_colour;
+								break;
+							case V4L2_CID_CONTRAST:
+								c->default_value = dev->vsettings.default_contrast;
+								break;
+						}
 						break;
 					}
 				}
diff --git a/stk11xx.h b/stk11xx.h
index a633b32..719d2fb 100644
--- a/stk11xx.h
+++ b/stk11xx.h
@@ -299,6 +299,12 @@ struct stk11xx_video {
 	int vflip;							/**< Vertical flip */
 	int input;                          /**< Input for multiinput cards */
 	int norm;							/**< Norm, NTSC or PAL */
+
+	/* Default values for the device. Above are values currently in use. */
+	int default_brightness;
+	int default_contrast;
+	int default_colour;
+	int default_whiteness;
 };
 
 
-- 
1.7.0.4

[Syntekdriver-devel] [PATCH 0/9] Patches from Cristi and build fix for 2.6.38+

[Peter S. <pe...@st...>]

Hello,

I've fixed up Cristi's patches against trunk and added a few fixes of
my own. My git tree is available at

http://git.stuge.se/?p=stk11xx-driver.git

and the individual patches will follow in reply to this message.


Kind regards

//Peter

Re: [Syntekdriver-devel] Hello? Are there any maintainers? I posted at least 3 important patches :-(

[Cristi P <cri...@gm...>]

I also added the patches to Mandriva's bug report system, in case they
decide to incorporate them faster...


2011/3/19 Cristi P <cri...@gm...>

> I attached the patches. The one fixing the S_FMT and TRY_FMT is a bit
> changed to remove some spurious lines it got when I put them on sourceforge.
> I tested the patches to see if they apply ok on a clean 2.1.0 svn checkout.
>
> Regards.
>
>
>
> 2011/3/12 Iker Salmón San Millán <sh...@es...>
>
>> Hi, Cristi
>>
>> I am not any of the  developer of this driver, and i am not pretty sure
>> how much activite is in here, but this mailing list was created short ago by
>> nikolas, so i guess that the project is still alive.  Any way, I've seen
>> your patches in the forum, i am really interested in obtaining them and (i
>> don't know what is your distro) maybe i'll give it a shot and try to include
>> this driver in debian packages.
>>
>> Cand you please send me thoose patches? I can't see any way to download
>> them from the forum.
>>
>> Thanks iker
>>
>>
>> 2011/3/12 Cristi P <cri...@gm...>
>>
>>> Hi!
>>> I posted several patches like ~1 week ago, 2 of them fixing computer
>>> freezes, 1 a segfault in a common v4l library.
>>> Haven't see anything happening to them.
>>> Is this project still maintained or should I go and ask my distro
>>> maintainers to include those patches?
>>>
>>> Regards.
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Colocation vs. Managed Hosting
>>> A question and answer guide to determining the best fit
>>> for your organization - today and in the future.
>>> http://p.sf.net/sfu/internap-sfd2d
>>> _______________________________________________
>>> Syntekdriver-devel mailing list
>>> Syn...@li...
>>> https://lists.sourceforge.net/lists/listinfo/syntekdriver-devel
>>>
>>>
>>
>

Re: [Syntekdriver-devel] Hello? Are there any maintainers? I posted at least 3 important patches :-(

[Cristi P <cri...@gm...>]

I attached the patches. The one fixing the S_FMT and TRY_FMT is a bit
changed to remove some spurious lines it got when I put them on sourceforge.
I tested the patches to see if they apply ok on a clean 2.1.0 svn checkout.

Regards.


2011/3/12 Iker Salmón San Millán <sh...@es...>

> Hi, Cristi
>
> I am not any of the  developer of this driver, and i am not pretty sure how
> much activite is in here, but this mailing list was created short ago by
> nikolas, so i guess that the project is still alive.  Any way, I've seen
> your patches in the forum, i am really interested in obtaining them and (i
> don't know what is your distro) maybe i'll give it a shot and try to include
> this driver in debian packages.
>
> Cand you please send me thoose patches? I can't see any way to download
> them from the forum.
>
> Thanks iker
>
>
> 2011/3/12 Cristi P <cri...@gm...>
>
>> Hi!
>> I posted several patches like ~1 week ago, 2 of them fixing computer
>> freezes, 1 a segfault in a common v4l library.
>> Haven't see anything happening to them.
>> Is this project still maintained or should I go and ask my distro
>> maintainers to include those patches?
>>
>> Regards.
>>
>>
>> ------------------------------------------------------------------------------
>> Colocation vs. Managed Hosting
>> A question and answer guide to determining the best fit
>> for your organization - today and in the future.
>> http://p.sf.net/sfu/internap-sfd2d
>> _______________________________________________
>> Syntekdriver-devel mailing list
>> Syn...@li...
>> https://lists.sourceforge.net/lists/listinfo/syntekdriver-devel
>>
>>
>

Re: [Syntekdriver-devel] Hello? Are there any maintainers? I posted at least 3 important patches :-(

[Iker S. S. M. <sh...@es...>]

Hi, Cristi

I am not any of the  developer of this driver, and i am not pretty sure how
much activite is in here, but this mailing list was created short ago by
nikolas, so i guess that the project is still alive.  Any way, I've seen
your patches in the forum, i am really interested in obtaining them and (i
don't know what is your distro) maybe i'll give it a shot and try to include
this driver in debian packages.

Cand you please send me thoose patches? I can't see any way to download them
from the forum.

Thanks iker


2011/3/12 Cristi P <cri...@gm...>

> Hi!
> I posted several patches like ~1 week ago, 2 of them fixing computer
> freezes, 1 a segfault in a common v4l library.
> Haven't see anything happening to them.
> Is this project still maintained or should I go and ask my distro
> maintainers to include those patches?
>
> Regards.
>
>
> ------------------------------------------------------------------------------
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> _______________________________________________
> Syntekdriver-devel mailing list
> Syn...@li...
> https://lists.sourceforge.net/lists/listinfo/syntekdriver-devel
>
>

[Syntekdriver-devel] Hello? Are there any maintainers? I posted at least 3 important patches :-(

[Cristi P <cri...@gm...>]

Hi!
I posted several patches like ~1 week ago, 2 of them fixing computer
freezes, 1 a segfault in a common v4l library.
Haven't see anything happening to them.
Is this project still maintained or should I go and ask my distro
maintainers to include those patches?

Regards.

Re: [Syntekdriver-devel] make: fails to build external module if there are spaces in the module path

[Iker S. S. M. <sh...@es...>]

El 23 de febrero de 2011 00:14, Jonathan Nieder <jrn...@gm...>escribió:

> Hi!
>
> Iker Salmón wrote:
>
> > Trying to compile an external webcam driver fails if there are spaces in
> the
> > path of the driver:
>
> Do you have a copy of the makefile?  Where does the driver come from?
>
>
The driver is for syntek webcam, it was included in kernel 2.6.24.  It was
stk11xx, but the new stkwebcam driver doesn't work anymore with some models:

http://sourceforge.net/projects/syntekdriver/

the Makefile:

---code--------------------------------------------
stk11xx-objs := stk11xx-usb.o stk11xx-v4l.o stk11xx-sysfs.o stk11xx-dev.o
stk11xx-buf.o stk11xx-bayer.o

stk11xx-objs += stk11xx-dev-0408.o
stk11xx-objs += stk11xx-dev-0500.o
stk11xx-objs += stk11xx-dev-0501.o
stk11xx-objs += stk11xx-dev-a311.o
stk11xx-objs += stk11xx-dev-a821.o
stk11xx-objs += stk11xx-dev-6a31.o
stk11xx-objs += stk11xx-dev-6a33.o
stk11xx-objs += stk11xx-dev-6a51.o
stk11xx-objs += stk11xx-dev-6a54.o

obj-$(CONFIG_STK11XX) += stk11xx.o
----code------------------------------------------------------

it also has Mafekile.standalone file.  To compile you have to:   make -f
Makefile.standalone

Makefile.standalone:
-----code---------------------------------------------------------
KVER=$(shell uname -r)
KSRC=/lib/modules/$(KVER)/build


all: driver

doc:
        @echo "Generating document with Doxygen..."
        @doxygen doxygen.cfg

driver:
        $(MAKE) -C $(KSRC) SUBDIRS=$(PWD) modules
        @ctags -R

clean:
        $(MAKE) -C $(KSRC) SUBDIRS=$(PWD) clean
        @rm -f Module.symvers

cleandoc:
        @echo "Removing documentation generated by Doxygen..."
        @rm -Rf ../doxygen

------code--------------------------------------------





> > make -C /lib/modules/2.6.37-1-686/build SUBDIRS=/home/duffy/Programas y
> drivers/Compilar/driver modules
> [...]
> > I didn't now against wich package to report this, please reasign where it
> belongs.
>
> It belongs to the author of the driver's makefile, I believe.

Well, i don't know.  It works perfect in squeeze, after upgrading to testing
appears the issue



> I'd suggest building from a path without spaces in it, lame as that might
> sound.
>
>
Yeah, i allready did that, but i thoutgh i had to report it



> Hope that helps,
> Jonathan
>

Sure, thanks for your response, but if you (or whoever) don't mind, i would
like to know if i should report this to the driver authors and if there is
something else relevant to tell him.

I'll cc this email to the mailing list


Thanks

Iker

Re: [Syntekdriver-devel] compiling the driver against 2.6.37 kernel

[Iker S. S. M. <sh...@es...>]

Nevermind, it's a debian bug, It compiles well if there is no spaces in the
path to the driver.

Cheers
Iker

El 22 de febrero de 2011 17:00, Iker Salmón San Millán
<sh...@es...>escribió:

>
>
> El 22 de febrero de 2011 15:41, Iker Salmón San Millán <
> sh...@es...> escribió:
>
> Hi, i am trying to compile the driver against this kernel and i can't do
>> it.
>>
>> I've tried with your own make-file and also with this other one:
>>
>> http://bookeldor-net.info/merdier/Makefile-syntekdriver
>>
>> In both case i get an error:
>>
>>
>> make[3]: *** No hay ninguna regla para construir el objetivo `y'.  Alto.
>>
>> (there is no rule to build the target `y'. halt.)
>> i've been messing up with your Makefile with no success (changing KVER
>> because before it was configured to work with an especific kernel version
>> and not with uname -r)
>>
>> Can you please give me a tip to what to do?
>>
>> Thanks
>>
>> Iker
>>
>>
>>
>> Ok, i've seen the patch sent by Death Knight® but it doesn't work for me.
> The issue seems to be that is not passing correctly the arguments.  why
> target `y'?  i am confused with that.
>
> I am using debian testing.
>
>
>

Re: [Syntekdriver-devel] compiling the driver against 2.6.37 kernel

[Iker S. S. M. <sh...@es...>]

El 22 de febrero de 2011 15:41, Iker Salmón San Millán
<sh...@es...>escribió:

> Hi, i am trying to compile the driver against this kernel and i can't do
> it.
>
> I've tried with your own make-file and also with this other one:
>
> http://bookeldor-net.info/merdier/Makefile-syntekdriver
>
> In both case i get an error:
>
>
> make[3]: *** No hay ninguna regla para construir el objetivo `y'.  Alto.
>
> (there is no rule to build the target `y'. halt.)
> i've been messing up with your Makefile with no success (changing KVER
> because before it was configured to work with an especific kernel version
> and not with uname -r)
>
> Can you please give me a tip to what to do?
>
> Thanks
>
> Iker
>
>
>
> Ok, i've seen the patch sent by Death Knight® but it doesn't work for me.
The issue seems to be that is not passing correctly the arguments.  why
target `y'?  i am confused with that.

I am using debian testing.

[Syntekdriver-devel] compiling the driver against 2.6.37 kernel

[Iker S. S. M. <sh...@es...>]

Hi, i am trying to compile the driver against this kernel and i can't do it.

I've tried with your own make-file and also with this other one:

http://bookeldor-net.info/merdier/Makefile-syntekdriver

In both case i get an error:


make[3]: *** No hay ninguna regla para construir el objetivo `y'.  Alto.

(there is no rule to build the target `y'. halt.)
i've been messing up with your Makefile with no success (changing KVER
because before it was configured to work with an especific kernel version
and not with uname -r)

Can you please give me a tip to what to do?

Thanks

Iker

[Syntekdriver-devel] Welcome & test

[Nicolas <pr...@fr...>]

Hi,

Now we can use mailing list instead of forum.

Regards,

Nicolas