Menu

Volume of ogg files lower with 1.66?

2006-01-02
2013-04-25
  • mrcreativity

    mrcreativity - 2006-01-02

    Has anyone noticed the the volume of ogg files in the phone gallery and when set as ringtone is considerably lower as compared to ver 1.65MMF?

    The volume in the player is louder than ever (thaks for that btw), but when set as ringtones, its just too low. Reminds me of when i had a 6600.

     
    • Francis Devereux

      Yes I've noticed it too, it is happening because there is a small bug in the volume boost feature that was introduced to the latest MMF version.  The gain is not being initialised in some places it needs to be, so it ends up being set to the lowest possible value.  This doesn't matter inside the OggPlay application, because that always sets the gain to whatever you've chosen in the preferences, but outside the application (e.g. when you're using an ogg as a ringtone).

      The following patch fixes it (can someone commit this?):

      diff -ur symbianoggplay-20060103/Plugin/src/OggPlayController.cpp symbianoggplay/Plugin/src/OggPlayController.cpp
      --- symbianoggplay-20060103/Plugin/src/OggPlayController.cpp    2006-01-03 20:59:36.437500000 +0000
      +++ symbianoggplay/Plugin/src/OggPlayController.cpp     2006-01-03 21:33:00.000000000 +0000
      @@ -742,6 +742,7 @@
         MDataSource(TUid::Uid(KOggTremorUidPlayFormatImplementation)),
         iSampleRateFillBuffer(aSampleRateFillBuffer)
      {
      +    iGain = ENoGain;
      }

      COggSource::~COggSource()
      diff -ur symbianoggplay-20060103/src/OggPluginAdaptor.cpp symbianoggplay/src/OggPluginAdaptor.cpp
      --- symbianoggplay-20060103/src/OggPluginAdaptor.cpp    2006-01-03 20:59:37.343750000 +0000
      +++ symbianoggplay/src/OggPluginAdaptor.cpp     2006-01-03 21:36:45.953125000 +0000
      @@ -222,6 +222,7 @@
      iEnv(anEnv)
      {
           iVolume = KMaxVolume;
      +    iGain = ENoGain;
      }

      TInt COggPluginAdaptor::Info(const TDesC& aFileName, TBool /*silent*/)

      If you want the fix now you can try http://www.devrx.org/software/symbian/oggplay/OggPlayMMF.s60.20060103.fjd.sis

      Francis

       
      • Francis Devereux

        P.S. maybe the plugin could read the gain from the settings when it is being used outside the app?

         
    • Stuart Fisher

      Stuart Fisher - 2006-01-05

      Good work Francis! I'll make the changes and check them in at some point. Of course you could just email Leif and ask to be added as a developer and then check them in yourself, how about it?

      Stuart

       
      • Francis Devereux

        I've emailed him :)  Providing he's willing to add me I'll get the changes checked in over the weekend.

        Francis

         
    • Stuart Fisher

      Stuart Fisher - 2006-01-07

      Ok, that's cool. If Leif doesn't get around to adding you before the end of the weekend I'll checkin the changes. I want to try and get a S60 1.67 (and a S80 1.67) released early next week.

       

Log in to post a comment.