From: Jake H. <jh...@po...> - 2005-01-31 22:07:10
|
Daniel Gryniewicz wrote: > Hey, Jake. > > It looks like dlist.h got checked in as a DOS file, rather than as a > UNIX file (ie, it has \r\n). CVS doesn't handle this very well. Would > it be possible to run dos2unix on it, and check in the result? > > Note that there are a number of other files with the same problem in the > kernel. Since Syllable uses the Unix text file format, it seems to me > that we should standardize on that for our source. Oops. I got some messages about CR's being stripped when I applied your patches but I didn't think about that when I added dlist.h. I'll do a search for DOS-formatted text files and update any that I find. It's my fault for saving your attachments from Thunderbird in Windows. > I actually develop on Linux using Vim, 'cause Syllable's not yet ready > to be my main OS on my laptop. I have dos2unix available. However, I > don't have CVS access, so I can't fix things myself. I can make the > changes locally, but then I end up with huge, annoying diffs locally... > (as would presumably happen with Sourcery, too.) Have you tried Vim under Syllable? If you set the Terminal background color to white then the color syntax highlighting looks pretty good. It's nice being able to use the same editor on Linux, Windows and Syllable. But I assume you are using Linux on your laptop for other reasons. Out of curiosity, what 802.11 driver are you using, if any? One of these days I would like to try to port the madwifi driver from Linux so I can use the Atheros chipset in my Fujitsu. I had to upgrade the version of madwifi in FreeBSD a while back when I was using that OS on my laptop so I know my way around the code a little bit. Anyway, if you haven't already, please merge your work with the current version of the kernel ("Build 0002") in CVS. Arno's patches changed a number of function names and moved a few things around, so it'll be a lot easier for me to integrate your next set of scheduler diffs when you're ready. I haven't yet merged your first two sched-cleanup patches, but I'm assuming that I just need to change LIST_ to DLIST_. I'll post a message here when I've committed those patches so you could also wait until then to sync up. -Jake |